Closed Bug 321283 Opened 19 years ago Closed 18 years ago

using Find causes documents to leak

Categories

(Toolkit :: Find Toolbar, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: dbaron)

Details

(Keywords: fixed1.8.0.2, fixed1.8.1, memory-leak, Whiteboard: [patch][rft-dl])

Attachments

(1 file)

If I use Find, the document I found the text in leaks, along with a
few chrome documents, such as
chrome://global/content/platformHTMLBindings.xml.

Details that might or might not matter:
* I start Find with Cmd+F, type some text that exists in the page, press Esc, and then quit the browser immediately.
* If I select text by dragging instead of using Find, nothing leaks.
* The patch on bug 315708 doesn't seem to help.
* I tested on http://www.squarefree.com/start/ and http://en.wikipedia.org/wiki/1 through 5.

Setup:
* This is with a trunk debug build on Mac with dbaron's leak-detecting stuff.
* I disabled all of my extensions before testing.
Attached patch patchSplinter Review
This fixes at least the main leak, which was two leaked references to a pres context for each call into this code.
Attachment #206650 - Flags: review?
Attachment #206650 - Flags: review? → review?(bryner)
I tried the patch.  The leaks of chrome:// documents are gone.  Now I just see a DOMWindow leak:

Leaked outer window 20af33e0 at address 20af33e0.
Leaked inner window 226802d0 (outer 20af33e0) at address 226802d0.
 ... with URI "http://www.squarefree.com/start/"".
That last leak may well be fixed by bug 315708, and in any case I think I've tested that it's just a single object held longer than it should be (and if you repeat the action, another one replaces it).
Flags: blocking1.8.0.2?
Attachment #206650 - Flags: review?(bryner) → review+
Fix checked in to trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Is this bug really specific to Mac OS X?
No.
OS: MacOS X → All
Hardware: Macintosh → All
Flags: blocking1.8.0.2?
Flags: blocking1.8.0.2+
Flags: blocking-firefox2+
Comment on attachment 206650 [details] [diff] [review]
patch

I assume we want this in 1.8.1 as well?
Attachment #206650 - Flags: approval1.8.0.2?
Attachment #206650 - Flags: approval-branch-1.8.1?(bryner)
Comment on attachment 206650 [details] [diff] [review]
patch

of course.
Attachment #206650 - Flags: approval-branch-1.8.1?(bryner) → approval-branch-1.8.1+
Comment on attachment 206650 [details] [diff] [review]
patch

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #206650 - Flags: approval1.8.0.2? → approval1.8.0.2+
Fix checked in to MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH.
Jesse, any chance you can quickly verify this patch on the 180 branch?  If you do, please change the fixed1.8.0.2 keyword to verified1.8.0.2.
Whiteboard: [patch] → [patch][rft-dl]
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.