321294 - ReplaceFrame codepaths seems unused

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

On my new travels into layout code I ran into the ReplaceFrame function and wondered if it might be old remains from when we used to have a separate codepath for ReplaceChild (see bug 237566). Looks like that is largly the case.

The only callers of this function (and DoReplaceFrame) is other implementations of the function and nsMathMLContainerFrame::WrapForeignFrames.

See http://lxr.mozilla.org/mozilla/search?string=replaceframe

Can we switch nsMathMLContainerFrame::WrapForeignFrames to use something else and kill this code?

Comment 1

[rbs]

Yes. WrapForeignFrames() is going to be removed anytime now when I check in the patch that I submitted for bug 309120.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Awesome! I'll gladly remove ReplaceFrame after that.

Comment 3

[rbs]

WrapForeignFrames() is now gone... 

(Since nsMathMLForeignFrameWrapper.cpp/.h are not used anymore, I plan to also cvs-removed them.)

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to fix

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in, thanks for the quick review

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Feel free to send me reviews if you don't specifically need bz.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Will do :)