321379 - Crash using a closed stream [@ nsConverterOutputStream::Close][@ nsConverterOutputStream::Write]

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P1)

Description

[timeless]

I wasn't trying to crash it, but, it did when i forgot i had closed the stream.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

(patch v2 also fixes write/writeString)

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on trunk:
Checking in intl/uconv/src/nsConverterOutputStream.cpp;
/cvsroot/mozilla/intl/uconv/src/nsConverterOutputStream.cpp,v  <--  nsConverterOutputStream.cpp
new revision: 1.2; previous revision: 1.1
done

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on MOZILLA_1_8_BRANCH
Checking in intl/uconv/src/nsConverterOutputStream.cpp;
/cvsroot/mozilla/intl/uconv/src/nsConverterOutputStream.cpp,v  <--  nsConverterOutputStream.cpp
new revision: 1.1.4.1; previous revision: 1.1
done

Comment 6

[timeless]

Comment on attachment 206738 [details] [diff] [review]
patch v2 

Incident ID: 19887900

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 206738 [details] [diff] [review]
patch v2 

approved for 1.8.0 branch, a=dveditz for drivers

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in on MOZILLA_1_8_0_BRANCH:

Checking in intl/uconv/src/nsConverterOutputStream.cpp;
/cvsroot/mozilla/intl/uconv/src/nsConverterOutputStream.cpp,v  <--  nsConverterOutputStream.cpp
new revision: 1.1.12.1; previous revision: 1.1
done

Comment 9

[alice nodelman [:alice] [:anode]]

Can I get a testcase for this bug?

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: unit test

sure, here it is. patch for applying in intl/uconv. Adds a make check target. (this bug can't be directly triggered by users, only by extensions)

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

unit test checked in on trunk:
Checking in tests/Makefile.in;
/cvsroot/mozilla/intl/uconv/tests/Makefile.in,v  <--  Makefile.in
new revision: 1.24; previous revision: 1.23
done
RCS file: /cvsroot/mozilla/intl/uconv/tests/unit/test_bug321379.js,v
done
Checking in tests/unit/test_bug321379.js;
/cvsroot/mozilla/intl/uconv/tests/unit/test_bug321379.js,v  <--  test_bug321379.js
initial revision: 1.1
done