321563 - Week View fails to display sunday events after selecting 'Go to Today'

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Stefan Sitter [:ssitter]]

Week View fails to display events after selecting 'Go to Today'

Steps to reproduce:
- Select the current week
- Create one event on every day (Sun to Sat) e.g. at noon --> events are created
- Check the display in the views --> everything seem ok
- Select the current day in month view
- Switch to week view   --> Events from Sun to Sat are displayed ok
- Select 'Go to Today'  --> No event is displayed on Sunday!
                        --> Events from Mon to Sat are displayed ok

Happens only if Sunday is selected as first day of week (default), no problems if I select another day.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051226 Mozilla Sunbird/0.3a1+ with clean profile.

Comment 1

[Joey Minta]

This sounds to me like it could be a timezone issue.  (Actually, this, bug 321560, and bug 321562 all do)  Without having looked too deeply into this, I wouldn't be surprised if this was the same thing as bug 321562.  Questions that come to mind:
(1) What is the query start date that calendar-multiday-view is using here?  
(2) Are events getting returned via getItems and then being discarded, or are they never returning from the query?
(3) What makes you think this bug is distinct from bug 321562?  Both seem to have problems displaying events at the beginning of the range.

See also bug 315954, which seems to describe a similar, but reverse problem.

Comment 2

[Stefan Sitter [:ssitter]]

(In reply to comment #1)
> This sounds to me like it could be a timezone issue.

Hi Joey,

I'm not sure about this point. My local timezone is GMT+1. From the console I can see that Sunbird gets the correct timezone. If this was a timezone issue (as seen before) I would expect the event to be shifted by +/- one hour. But the event is not displayed at all.

> (3) What makes you think this bug is distinct from bug 321562?  Both seem to
> have problems displaying events at the beginning of the range.

Yeah, but I see this error in week view only if Sunday is selected as first day of the week (in the sunbird options). If any of the other days is selected as first day of the week all events are shown, from the first to the last visible day (e.g. from Monday to Sunday).
To me it seems that this is maybe another problem. So I decided to write a own bug for that problem. 

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: patch

Setting isDate to true fixes the problems for me. 
(Patch also replaces one tab with spaces)

Comment 4

[Joey Minta]

Comment on attachment 207921 [details] [diff] [review]
patch

After discussion in IRC, this should probably be patched in calendar-multiday-view.xml

Comment 5

[Stefan Sitter [:ssitter]]

Attachment: patch, v2

Alter setDateRange to always store startDate and endDate as date object. This should also fix bug 321562 and bug 321753.

Comment 6

[Joey Minta]

Comment on attachment 208306 [details] [diff] [review]
patch, v2

Fixing 3 bugs with 4 lines, how can you not like that? This looks much better. r=jminta

It'd be nice to get this documented somewhere, probably somewhere close to the devmo docs on calICalendarView.

Comment 7

[Joey Minta]

patch checked in :-)

Comment 8

[Joey Minta]

*** Bug 321562 has been marked as a duplicate of this bug. ***

Comment 9

[Joey Minta]

*** Bug 321753 has been marked as a duplicate of this bug. ***