[Mac] Support Command+Option+Arrows for tab switching (like Camino)

RESOLVED FIXED in seamonkey1.1alpha

Status

SeaMonkey
UI Design
--
minor
RESOLVED FIXED
12 years ago
9 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

(4 keywords)

Trunk
seamonkey1.1alpha
PowerPC
Mac OS X
fixed-seamonkey1.0, fixed-seamonkey1.1a, fixed1.8.0.1, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.71 KB, patch
stefanh
: review+
neil@parkwaycc.co.uk
: superreview+
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com]
: approval-seamonkey1.0+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
This is the xpfe version of bug 275519.
(Assignee)

Comment 1

12 years ago
Created attachment 206913 [details] [diff] [review]
Make cmd+opt+left/right arrow switch tab on mac

It seems that all field names starts with an underscore (and a few properties as well) so I kept the underscore.
Attachment #206913 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #206913 - Flags: review?(mnyromyr)

Comment 2

12 years ago
Comment on attachment 206913 [details] [diff] [review]
Make cmd+opt+left/right arrow switch tab on mac

I'm not particularly happy with that keys, but since we will "have to buy" them with toolkit later anyways, we might as do so now...
Otherwise okay.
Attachment #206913 - Flags: review?(mnyromyr) → review+

Comment 3

12 years ago
Comment on attachment 206913 [details] [diff] [review]
Make cmd+opt+left/right arrow switch tab on mac

Assuming we're not going to change the value you can in fact declare it (without underscore) in the event handler. Or just inline the regexp. Or just ignore it and wait for other platforms with Cmd+Option+Arrow to complain ;-)

Nit: doubled space in two of the if statements.
(Assignee)

Comment 4

12 years ago
Created attachment 207352 [details] [diff] [review]
New version using a constant instead of <field/>

Hmm, should I prefix the constant with a "k"? Looks like no one follows the rules... (transferring mnyromyr's r+)
Attachment #206913 - Attachment is obsolete: true
Attachment #207352 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #207352 - Flags: review+
Attachment #206913 - Flags: superreview?(neil.parkwaycc.co.uk)

Updated

12 years ago
Attachment #207352 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+

Comment 5

12 years ago
Comment on attachment 207352 [details] [diff] [review]
New version using a constant instead of <field/>

a=me for 1.0 and 1.1, one more needed for 1.0 though
Attachment #207352 - Flags: approval-seamonkey1.1+
Attachment #207352 - Flags: approval-seamonkey1.0?

Comment 6

12 years ago
Checked in on trunk and MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1
Attachment #207352 - Flags: approval-seamonkey1.0? → approval-seamonkey1.0+

Comment 7

12 years ago
Checked in on MOZILLA_1_8_0_BRANCH.
Keywords: fixed1.8.0.1

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Updated

12 years ago
Blocks: 322381
Verified on the branch using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060110 Firefox/1.5.0.1.
Keywords: fixed1.8.0.1 → verified1.8.0.1
(Assignee)

Comment 9

12 years ago
(In reply to comment #8)
> Verified on the branch using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O;
> en-US; rv:1.8.0.1) Gecko/20060110 Firefox/1.5.0.1.

Marcia, did you noticed that the "product" is Mozilla App Suite?

Since Marcia verified this with a Fx build instead of a SM one. Removing verified1.8.0.1 keyword.
Keywords: verified1.8.0.1 → fixed1.8.0.1
Stefan: Sorry, this was coming up in our query and I did not look at the product closely (did it with another bug too). thanks for Samuel for correcting the keyword.

(In reply to comment #9)
> (In reply to comment #8)
> > Verified on the branch using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O;
> > en-US; rv:1.8.0.1) Gecko/20060110 Firefox/1.5.0.1.
> 
> Marcia, did you noticed that the "product" is Mozilla App Suite?
> 

(Assignee)

Updated

11 years ago
Keywords: fixed-seamonkey1.0, fixed-seamonkey1.1a

Updated

9 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.