Closed Bug 321667 Opened 19 years ago Closed 18 years ago

Timer-related leak in extension update code

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Version:
1.8 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1beta1

People

(Reporter: dbaron, Unassigned)

References

Details

(Keywords: memory-leak)

I didn't check in the 4th file in the patch on bug 315951. This shows a timer-related memory leak. However, fixing the leak actually increases the leak numbers, so something else is probably leaking.
Blocks: 336955
Flags: blocking-firefox2?
perhaps fixed by the patch in #336955
Please forgot comment #2 sorry.
Flags: blocking-firefox2? → blocking-firefox2+
Keywords: helpwanted
Target Milestone: --- → Firefox 2 beta1
Assignee: dbaron → michael.wu
Severity: normal → minor
Whiteboard: [SWAG: 2d]
How do I test/reproduce this?
See comment 1. In particular, set up a profile with an older version such that you have an incompatible extension on startup (and then keep recopying the profile for each test).
Flags: blocking-firefox2+
Assignee: michael.wu → nobody
Looks like this code was either removed or moved as part of bug 342606.
Yeah, this was fixed by bug 342606. Robert removed the nsITimerCallback implementation that wasn't clearing its timers when it was destroyed: https://bugzilla.mozilla.org/attachment.cgi?id=228222&action=diff#mozilla/toolkit/mozapps/extensions/content/update.xml_sec1. Marking as FIXED.
Severity: minor → normal
Status: NEW → RESOLVED
Closed: 18 years ago
Component: Software Update → Extension/Theme Manager
Keywords: helpwanted
OS: Linux → All
QA Contact: software.update → extension.manager
Hardware: PC → All
Resolution: --- → FIXED
Summary: timer-related leak in update code → Timer-related leak in extension update code
Whiteboard: [SWAG: 2d]
Version: unspecified → 2.0 Branch
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.