321691 - duplicates.cgi doesn't use <th>

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect)

Description

[timeless]

most of bugzilla is nice and uses th, but duplicates does not.

Comment 1

[timeless]

Attachment: use <thead>, <th>, <tbody>

Comment 2

[Frédéric Buclin]

Comment on attachment 206979 [details] [diff] [review]
use <thead>, <th>, <tbody>

>+          <th>
>+            [% bug_ids_string = bug_ids.join(',') %]
>+            <a href="duplicates.cgi?sortby=[% column.name %]
>+              [% IF sortby == column.name %]
>+                [% "&amp;reverse=1" IF NOT reverse %]
>+              [% ELSE %]
>+                [%-# Some columns start off reversed %]
>+                [% "&amp;reverse=1" IF column.name.match('delta|count') %]
>+              [% END %]
>+              [% "&amp;maxrows=$maxrows" IF maxrows %]
>+              [% "&amp;changedsince=$changedsince" IF changedsince %]
>+              [% "&amp;openonly=1" IF openonly %]
>+              [% FOREACH p = query_products %]&amp;product=[% p FILTER html %][% END %]
>+              [% IF format %]&amp;format=[% format FILTER html %][% END %]
>+              [% "&amp;bug_id=$bug_ids_string&amp;sortvisible=1" 
>+                                                          IF sortvisible %]">
>+              [% column.description %]</a>
>+          </td>


This block is incorrect. You have <th></td>. What's the correct tag?

Comment 3

[timeless]

doh, it's a header, correct tag is /th

Comment 4

[timeless]

Attachment: use <thead>, <th></th>, <tbody>

Comment 5

[Frédéric Buclin]

Comment on attachment 206999 [details] [diff] [review]
 use <thead>, <th></th>, <tbody>

this patch doesn't pass tests:

not ok 220 - (en/default) template/en/default/reports/duplicates-table.html.tmpl has unfiltered directives:
#   82: "&amp;bug_id=$bug_ids_string&amp;sortvisible=1"
#                                                           IF sortvisible
# --ERROR

#     Failed test (t/008filter.t at line 131)

Comment 6

[timeless]

Attachment: exceptions are stupid

Comment 7

[Frédéric Buclin]

Comment on attachment 207093 [details] [diff] [review]
exceptions are stupid

>Index: mozilla/webtools/bugzilla/template/en/default/reports/duplicates-table.html.tmpl

>+        [% FOREACH column = [ { name => "id", description => "$terms.Bug #" },
>+                              { name => "count", description => "Dupe<br>Count" },
>+                              { name => "delta",
>                         description => "Change in last<br>$changedsince day(s)" },
>+                              { name => "component", description => "Component" },
>+                              { name => "bug_severity", description => "Severity" },
>+                              { name => "op_sys", description => "Op Sys" },
>+                              { name => "target_milestone",
>                               description => "Target<br>Milestone" },
>+                              { name => "short_desc", description => "Summary" } ]
>+         %]

Please fix the indentation of the two descriptions (vertically aligned with 'name') on checkin.

r=LpSolit

Comment 8

[Frédéric Buclin]

timeless did the checkin, but didn't post the output. Here is was tinderbox says:

tip:

mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl rv1.61
mozilla/webtools/bugzilla/template/en/default/reports/duplicates-table.html.tmpl rv1.12