Closed Bug 321707 Opened 19 years ago Closed 17 years ago

Don't force this.select() in onfocus

Categories

(Core :: Printing: Output, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: vhaarr+bmo, Assigned: grapz)

References

()

Details

(Whiteboard: [good first bug])

Attachments

(1 obsolete file)

From bug 277296 comment 12:

"I noticed one or more instances of |onfocus="this.select()"| -- I think this is
really up to the OS if we should do or not. For GTK, for example, it's a system
pref. I didn't remove it, but maybe I should've (or in a seperate bug.)"
The job here is just to remove all instances of |onfocus="this.select()"| in printPageSetup.xul in both xpfe and toolkit, because this is really a per-OS system preference and we shouldn't override it.
Whiteboard: [good first bug]
Attached patch Version 1 (obsolete) — Splinter Review
My first go at a patch, let's hope I got it rigth ;)
Attachment #207228 - Flags: review?(timeless)
Attachment #207228 - Flags: superreview?(neil)
Attachment #207228 - Flags: review?(timeless)
Attachment #207228 - Flags: review+
Attachment #207228 - Flags: superreview?(neil) → superreview+
It looks like this still needs to be checked in. Is that correct?
Checked in by timeless, thanks!
Assignee: vhaarr+bmo → grapz
A quick search revealed 3 more:
<http://lxr.mozilla.org/seamonkey/source/mailnews/addrbook/resources/content/addressbook.xul#441>
<http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/mailWindowOverlay.xul#1935>
<http://lxr.mozilla.org/seamonkey/source/mailnews/base/search/resources/content/CustomHeaders.xul#77>

The first two appear to be search boxes, so I'm not sure if this really applies there or not. The third one could be fixed. If someone wants to do it in this bug, feel free - I'll leave it open for now.
Comment on attachment 207228 [details] [diff] [review]
Version 1

mozilla/xpfe/global/resources/content/printPageSetup.xul 	1.16
Attachment #207228 - Attachment is obsolete: true
I'm going to resolve this as FIXED. The issue in the original comment is fixed. The code identified in comment 5 isn't related to printing.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: