321807 - "Use this proxy server for all protocols" problem when change is canceled

Status: RESOLVED WORKSFORME

(Firefox :: Settings UI, defect)

Description

[Alfred Peng]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8) Gecko/20051226 Firefox/1.5
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8) Gecko/20051226 Firefox/1.5

I found two problems in the "connection settings" window.
Steps to Reproduce for #1:
1. Edit->preferences->connection settings
2. Input proxy server info into the "HTTP Proxy"
3. Check the checkbox of "Use this proxy server for all protocols"

Actual Results:
All the proxies below including "SOCKS Host" changes accordingly.

Expected Results:
The "SOCKS Host" info doesn't change.

Steps to Reproduce for #2:

Reproducible: Always

Steps to Reproduce:
1. Edit->preferences->connection settings
2. Uncheck the checkbox of "Use this proxy server for all protocols"
3. Input proxy server info into the "HTTP Proxy", "SSL Proxy", "FTP Proxy" and Click OK
4. Click "connection settings" again, check the checkbox of "Use this proxy server for all protocols" and click OK
5. Click "connection settings" again, uncheck the checkbox of "Use this proxy server for all protocols" and click Cancel
6. Click "connection settings" one more time, uncheck the checkbox of "Use this proxy server for all protocols"
Actual Results:  
The proxy servers info user inputs disappears.

Expected Results:  
The proxy servers info user inputs can still be shown correctly in the corresponding textbox.

Comment 1

[Alfred Peng]

Attachment: Patch for trunk

The backup preference info shouldn't be reset when user uncheck the checkbox of "Use this proxy server for all protocols". The value should be changed when user click the OK button.
For the "readProxyProtocolPref" function, remove the useless part, return undefined instead.

Comment 2

[Mike Connor [:mconnor]]

Attachment: patch

Fixes the backup pref to not get reset on window close, and actually persists.  Also makes sure we don't copy socks from http, and does less weirdness/looping on changing the pref when the checkbox is ticked.

There's a small hack (commented) because of how onsynctopreference works, since onchange on <preference/> elements seems to fire twice, which I'll look at later.

Comment 3

[Ginn Chen]

Mike, any plan on this bug?

Comment 4

[Ginn Chen]

fwiw: this bug exists for both Firefox and Thunderbird

Comment 5

[benc]

Mike: I think this was fixed at some point, because I looked at FF3.0.1, and it doesn't happen.

If you unselect the "all protocols" checkbox, and cancel, it seems to operate correctly (and not change the prefs block).

Comment 6

[Arie Paap [:wildmyron]]

I don't think this is fixed. If I understand the second problem correctly it's been reported in bug 446536 and bug 451132. I am able to reproduce as reported in those bugs but I'm not sure if they're the same as this one.

Comment 7

[RNicoletto]

This is WFM using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10.

Comment 8

[Michael Kohler [:mkohler]]

This is a mass change. Every comment has "assigned-to-new" in it.

I didn't look through the bugs, so I'm sorry if I change a bug which shouldn't be changed. But I guess these bugs are just bugs that were once assigned and people forgot to change the Status back when unassigning.