321855 - Changes in PathTools 3.15 is breaking checksetup.pl

Status: RESOLVED INVALID

(Bugzilla :: Installation & Upgrading, defect)

Description

[Tim Thome]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7

On my dev box, updated PathTools to 3.15 (released on Dec 27th, 2005), checksetup is now choking... perl File::Path is throwing an error in Cwd::getcwd...

"Removing existing compiled templates ...
Usage: Cwd::getcwd() at /usr/lib/perl5/5.8.5/File/Path.pm line 267."

Host: Linux Fedora Core 3
Perl: 5.8.5
BZ: 2.21.1+ (off the tip)

In the changelist for PathTools, Cwd has changed.. see below:

"3.15  Tue Dec 27 14:17:39 CST 2005

 - The Cwd::getcwd() function on *nix is now a direct pass-through to
   the underlying getcwd() C library function when possible.  This is
   safer and faster than the previous implementation, which just did
   abs_path('.').  The pure-perl version has been kept for cases in
   which the XS version can't load, such as when running under
   miniperl. [Suggested by Nick Ing-Simmons]"

Still debugging, but this looks more like a dependency not on BZ itself, but might need to make changes to checksetup.pl to account for this. 

Reproducible: Always

Steps to Reproduce:
1. Update Bugzilla to tip (122905)
2. Run Checksetup.pl to update templates
3. Upgrade File::Spec via MCPAN, PathTools 3.15 was released on 122705, this will be updated - depending on perl and platform, you may have to force install this update.
4. Run Checksetup.pl again, the error will be thrown, checksetup will exit




[root@(hostname) ~]# uname -a
Linux (hostname removed) 2.6.12-1.1381_FC3 #1 Fri Oct 21 03:46:55 EDT 2005 i686 athlon i386 GNU/Linux
[root@(hostname) ~]# perl -v

This is perl, v5.8.5 built for i386-linux-thread-multi
 (snip)

[root@(hostname) ~]# perl -V
Summary of my perl5 (revision 5 version 8 subversion 5) configuration:
  Platform:
    osname=linux, osvers=2.6.9-1.906_elsmp, archname=i386-linux-thread-multi
    uname='linux tweety.build.redhat.com 2.6.9-1.906_elsmp #1 smp sun dec 12 22:58:08 est 2004 i686 i686 i386 gnulinux '
    config_args='-des -Doptimize=-O2 -g -pipe -m32 -march=i386 -mtune=pentium4 -Dversion=5.8.5 -Dmyhostname=localhost -Dperladmin=root@localhost -Dcc=gcc -Dcf_by=Red Hat, Inc. -Dinstallprefix=/usr -Dprefix=/usr -Darchname=i386-linux -Dvendorprefix=/usr -Dsiteprefix=/usr -Duseshrplib -Dusethreads -Duseithreads -Duselargefiles -Dd_dosuid -Dd_semctl_semun -Di_db -Ui_ndbm -Di_gdbm -Di_shadow -Di_syslog -Dman3ext=3pm -Duseperlio -Dinstallusrbinperl -Ubincompat5005 -Uversiononly -Dpager=/usr/bin/less -isr -Dinc_version_list=5.8.4 5.8.3 5.8.2 5.8.1 5.8.0'
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=define use5005threads=undef useithreads=define usemultiplicity=define
    useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
    use64bitint=undef use64bitall=undef uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='gcc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -DDEBUGGING -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/include/gdbm',
    optimize='-O2 -g -pipe -m32 -march=i386 -mtune=pentium4',
    cppflags='-D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -DDEBUGGING -fno-strict-aliasing -pipe -I/usr/local/include -I/usr/include/gdbm'
    ccversion='', gccversion='3.4.4 20050721 (Red Hat 3.4.4-2)', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='gcc', ldflags =' -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib
    libs=-lresolv -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lpthread -lc
    perllibs=-lresolv -lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
    libc=/lib/libc-2.3.6.so, so=so, useshrplib=true, libperl=libperl.so
    gnulibc_version='2.3.6'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E -Wl,-rpath,/usr/lib/perl5/5.8.5/i386-linux-thread-multi/CORE'
    cccdlflags='-fPIC', lddlflags='-shared -L/usr/local/lib'


Characteristics of this binary (from libperl): 
  Compile-time options: DEBUGGING MULTIPLICITY USE_ITHREADS USE_LARGE_FILES PERL_IMPLICIT_CONTEXT
  Built under linux
  Compiled at Dec 16 2005 14:49:03
  @INC:
    /usr/lib/perl5/5.8.5/i386-linux-thread-multi
    /usr/lib/perl5/5.8.5
    /usr/lib/perl5/site_perl/5.8.5/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.4/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.2/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.1/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.0/i386-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.5
    /usr/lib/perl5/site_perl/5.8.4
    /usr/lib/perl5/site_perl/5.8.3
    /usr/lib/perl5/site_perl/5.8.2
    /usr/lib/perl5/site_perl/5.8.1
    /usr/lib/perl5/site_perl/5.8.0
    /usr/lib/perl5/site_perl
    /usr/lib/perl5/vendor_perl/5.8.5/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.4/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.3/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.2/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.1/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.0/i386-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.5
    /usr/lib/perl5/vendor_perl/5.8.4
    /usr/lib/perl5/vendor_perl/5.8.3
    /usr/lib/perl5/vendor_perl/5.8.2
    /usr/lib/perl5/vendor_perl/5.8.1
    /usr/lib/perl5/vendor_perl/5.8.0
    /usr/lib/perl5/vendor_perl

[root@(hostname) bugzilla]# ./checksetup.pl

Checking perl modules ...
Checking for       AppConfig (v1.52)   ok: found v1.56
Checking for             CGI (v2.93)   ok: found v3.15
Checking for    Data::Dumper (any)     ok: found v2.121
Checking for    Date::Format (v2.21)   ok: found v2.22
Checking for             DBI (v1.38)   ok: found v1.50
Checking for      File::Spec (v0.84)   ok: found v3.15
Checking for      File::Temp (any)     ok: found v0.16
Checking for        Template (v2.08)   ok: found v2.14
Checking for      Text::Wrap (v2001.0131) ok: found v2005.0824
Checking for    Mail::Mailer (v1.67)   ok: found v1.67
Checking for    MIME::Base64 (v3.01)   ok: found v3.07
Checking for    MIME::Parser (v5.406)  ok: found v5.419
Checking for        Storable (any)     ok: found v2.15

The following Perl modules are optional:
Checking for              GD (v1.20)   ok: found v2.30
Checking for     Chart::Base (v1.0)    ok: found v2.3
Checking for     XML::Parser (any)     ok: found v2.34
Checking for       GD::Graph (any)     ok: found v1.43
Checking for GD::Text::Align (any)     ok: found v1.18
Checking for     PatchReader (v0.9.4)  ok: found v0.9.5
Checking for   Image::Magick (any)     ok: found v6.2.5

Checking user setup ...
Removing existing compiled templates ...
Usage: Cwd::getcwd() at /usr/lib/perl5/5.8.5/File/Path.pm line 267.

Comment 1

[Tim Thome]

Some more info... looks like it is PathTools-3.15 that is broken, at least for the local install... make test output below.

Tim

---------

[root@(host) PathTools-3.15]# make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/crossplatform....ok
        7/50 skipped: Can't load File::Spec::VMS
t/cwd..............ok 19/33Usage: Cwd::getcwd() at /usr/lib/perl5/5.8.5/File/Path.pm line 267.
# Looks like you planned 33 tests but only ran 19.
# Looks like your test died just after 19.
t/cwd..............dubious
        Test returned status 255 (wstat 65280, 0xff00)
DIED. FAILED tests 20-33
        Failed 14/33 tests, 57.58% okay
t/Functions........ok
t/rel2abs2rel......ok
t/Spec.............ok
        83/473 skipped: various reasons
t/taint............ok
t/tmpdir...........ok
t/win32............skipped
        all skipped: this is not win32
Failed Test Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/cwd.t      255 65280    33   28  84.85%  20-33
1 test and 90 subtests skipped.
Failed 1/8 test scripts, 87.50% okay. 14/583 subtests failed, 97.60% okay.
make: *** [test_dynamic] Error 255

Comment 2

[Tim Thome]

Reverted back to 3.14 of PathTools and things are working ok. Had other problems outside of BZ, so I'm pulling this bug back. Might want to note this in FAQ or the Wiki... 

here's a link to the diffs for CWD...

http://search.cpan.org/diff?from=PathTools-3.14&to=PathTools-3.15

Thanks!

Tim