321882 - [l10n] "Open in New Windows" and "Open in Tabs in New Window" are missing in Localizable.strings

Status: VERIFIED FIXED

(Camino Graveyard :: Translations, defect)

Description

[waverider]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051229 Camino/1.0b2
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051229 Camino/1.0b2

two phrases for bookmark context menu, "Open in New Windows" and "Open Tabs in New Window" are missing in Localizable.strings.

Reproducible: Always

Steps to Reproduce:

Comment 1

[waverider]

sorry, two phrases are "Open in New Windows" and "Open in Tabs in New Window".

Comment 2

[Chris Lawson (gone)]

Fixing summary. Apologies for bugspam.

cl

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Those strings in all their permutations seriously make my head hurt!

Updated strings file coming....

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Updated localizable.strings

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 207276 [details]
Updated localizable.strings

Can we get some checkin love here for our localizers?

Comment 6

[waverider]

re:comment #4
this patch works fine at Camino1.0b2. thanks a lot.

Comment 7

[Stuart Morgan]

As long as there's a new Localizable.strings file going in, I'm pretty sure "A web popup was blocked" (the tooltip on the popup blocker icon) is missing as well.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Adds web popup tooltip

Stuart's right, it was missing.  Any others while we're at it?

Comment 9

[Stuart Morgan]

Someone could run Camino for a while with -NSShowNonLocalizedStrings YES and see if anything else comes up...

Comment 10

[Ludovic Hirlimann [:Usul]]

(In reply to comment #9)
> Someone could run Camino for a while with -NSShowNonLocalizedStrings YES and
> see if anything else comes up...
> 

Stuart is this a command line argument or something that needs to be written either in a plist or in a variable ?

Comment 11

[Bruce Davidson]

Ludo: From ADC (http://developer.apple.com/documentation/MacOSX/Conceptual/BPInternational/Articles/StringsFiles.html#//apple_ref/doc/uid/20000005-96895) yes it appears its a command line option:

(camino path)/Camino.app/Contents/MacOS/Camino -NSShowNonLocalizedStrings YES
should do the trick.

Comment 12

[Bruce Davidson]

A quick run through Camino (latest private build, accessed all the menus and preference panes and the download window) appears to show that we're doing fairly well. The only ones it complained about were:

Camino[1446] CFLog (21): Localizable string "A web popup was blocked" not found in strings table "Localizable" of bundle CFBundle 0x6093d0 <.../Camino.app> (executable, loaded).
Camino[1446] CFLog (21): Localizable string "Select..." not found in strings table "Localizable" of bundle CFBundle 0x6093d0 <.../Camino.app> (executable, loaded).
Camino[1446] CFLog (21): Localizable string "Select..." not found in strings table "Localizable" of bundle CFBundle 0x6093d0 <.../Camino.app> (executable, loaded).
Camino[1446] CFLog (21): Localizable string "A web popup was blocked" not found in strings table "Localizable" of bundle CFBundle 0x6093d0 <.../Camino.app> (executable, loaded).

Comment 13

[Stuart Morgan]

And when "Select..." is added to the strings file, it will be possible to use the ellipsis it should be using, instead of the three periods that are being used because of it being in a source file.

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Localizable.strings for the General (Navigation) prefPane with "Select…"

Comment 15

[Samuel Sidler (old account; do not CC)]

We need this for 1.0.

Comment 16

[Simon Fraser [no longer active]]

Checkedin everywhere.