321894 - ASSERTION: RemovedAsPrimaryFrame called after PreDestroy: 'PR_FALSE'

Status: RESOLVED WORKSFORME

(Core :: Layout: Form Controls, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase.
When loading the testcase, I get this assertion:
###!!! ASSERTION: RemovedAsPrimaryFrame called after PreDestroy: 'PR_FALSE', fil
e c:/mozilla/mozilla/layout/forms/nsTextControlFrame.cpp, line 1437

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

This is basically a regression from bug 315752, I think -- we walk the out of flows twice.  :(

This code should really be more like DoDeletingFrameSubtree....

Comment 3

[Mats Palmgren (inactive)]

I did a quick hack making DoCleanupFrameReferences() walk the frames as in
bug 310638 and it made the assertion go away...

One difference I noticed between the two is that DoCleanupFrameReferences() does:

  aFrameManager->SetPrimaryFrameFor(content, nsnull);
  aFrame->RemovedAsPrimaryFrame(aPresContext);
  aFrameManager->ClearAllUndisplayedContentIn(content);

also for placeholders.
But DoDeletingFrameSubtree() only does it for the out-of-flow...

Comment 4

[Boris Zbarsky [:bzbarsky]]

(In reply to comment #3)
> One difference I noticed between the two is that DoCleanupFrameReferences()
> does:
> 
>   aFrameManager->SetPrimaryFrameFor(content, nsnull);
>   aFrame->RemovedAsPrimaryFrame(aPresContext);
>   aFrameManager->ClearAllUndisplayedContentIn(content);
> 
> also for placeholders.

The first is silly for placeholders, since it'll happen for the out-of-flow (happens for the content, not for a specific frame).

The second is silly because a placeholder is never the primary frame.

The third is silly because it'll happen for the out-of-flow (again happens for the content).

Comment 5

[Mats Palmgren (inactive)]

ok, then it shouldn't be hard to merge them I think.

Comment 6

[Martijn Wargers (dead)]

Still happening in current debug trunk build.

Comment 7

[Martijn Wargers (dead)]

Still happening in current debug trunk build.

Comment 8

[Mats Palmgren (inactive)]

WFM, mozilla-central on Linux and OSX.
I checked in the test as crashtest (it passed all platforms on MozillaTry):
http://hg.mozilla.org/mozilla-central/rev/7e404bb124f7

-> WORKSFORME