Closed
Bug 321958
Opened 19 years ago
Closed 11 years ago
nsPluginInstanceOwner::GetTagText seems to not handle dynamic DOM changes
Categories
(Core Graveyard :: Plug-ins, defect, P3)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla21
People
(Reporter: Biesinger, Assigned: benjamin)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
5.50 KB,
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
It looks like this method just caches the tag text in mTagText and never updates that copy.
|
||
Updated•19 years ago
|
Keywords: helpwanted
|
Assignee | |
Comment 1•11 years ago
|
||
Looks like this method is unused, I'm going to try and remove it completely.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #702843 -
Flags: review?(joshmoz)
Comment on attachment 702843 [details] [diff] [review] remove nsIPluginTagInfo.getTagText, rev. 1 Review of attachment 702843 [details] [diff] [review]: ----------------------------------------------------------------- Looks like you should also be getting rid of the "mTagText" member variable, as it's unused after this.
Attachment #702843 -
Flags: review?(joshmoz) → review-
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #702843 -
Attachment is obsolete: true
Attachment #703292 -
Flags: review?(joshmoz)
Attachment #703292 -
Flags: review?(joshmoz) → review+
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c808fa0206ac
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•