nsPluginInstanceOwner::GetTagText seems to not handle dynamic DOM changes

RESOLVED FIXED in mozilla21

Status

()

Core
Plug-ins
P3
normal
RESOLVED FIXED
12 years ago
5 years ago

People

(Reporter: Biesinger, Assigned: Benjamin Smedberg)

Tracking

Trunk
mozilla21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

It looks like this method just caches the tag text in mTagText and never updates that copy.
Keywords: helpwanted
(Assignee)

Comment 1

5 years ago
Looks like this method is unused, I'm going to try and remove it completely.
Assignee: nobody → benjamin
Keywords: helpwanted
Priority: -- → P3
(Assignee)

Comment 2

5 years ago
Created attachment 702843 [details] [diff] [review]
remove nsIPluginTagInfo.getTagText, rev. 1
Attachment #702843 - Flags: review?(joshmoz)

Comment 3

5 years ago
Comment on attachment 702843 [details] [diff] [review]
remove nsIPluginTagInfo.getTagText, rev. 1

Review of attachment 702843 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like you should also be getting rid of the "mTagText" member variable, as it's unused after this.
Attachment #702843 - Flags: review?(joshmoz) → review-
(Assignee)

Comment 4

5 years ago
Created attachment 703292 [details] [diff] [review]
remove nsIPluginTagInfo.getTagText, rev. 1.1
Attachment #702843 - Attachment is obsolete: true
Attachment #703292 - Flags: review?(joshmoz)

Updated

5 years ago
Attachment #703292 - Flags: review?(joshmoz) → review+
https://hg.mozilla.org/mozilla-central/rev/c808fa0206ac
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.