Closed
Bug 322059
Opened 19 years ago
Closed 16 years ago
Current year not visible in any view
Categories
(Calendar :: Calendar Frontend, defect)
Calendar
Calendar Frontend
Tracking
(Not tracked)
VERIFIED
FIXED
0.9
People
(Reporter: calum.mackay, Assigned: berend.cornelius09)
References
Details
Attachments
(5 files)
1.82 KB,
patch
|
jminta
:
first-review+
|
Details | Diff | Splinter Review |
2.57 KB,
patch
|
Details | Diff | Splinter Review | |
42.33 KB,
image/png
|
Details | |
36.18 KB,
image/png
|
Details | |
48.30 KB,
image/png
|
mvl
:
ui-review+
|
Details |
Linux/x86, my build today from CVS. An indication of the current year is not visible in any view. It's quite useful, when viewing an event for another year, to have a confirmation that you're looking at the right year. The old multi-week view definitely had this, at least.
Reporter | ||
Comment 1•19 years ago
|
||
Obviously, the year is visible if one is showing the "Date" panel in the sidebar; I'm referring to when that sidebar isn't open, or is set to "Calendar".
Comment 2•18 years ago
|
||
I support this wish. My suggestions: Day View: Display the date of the current day in the header bar including the year (dependent on os date format): 13.01.2006 Month view: Add the year to the middle button of the navigation bar: [November] [December] [January 2006] [February] [March] Week/Multiweek View: Maybe similar to the Month View? Like: [Week 2 2006] or [Week 1-5 2006]. But I'm not sure about that. Comments?
Comment 3•18 years ago
|
||
Yes, I too agree that the year should be displayed at all times. Imagine the siutation where you are viewing the calendar for months Dec, Jan, Feb and March. It would be useful if the year was shown. Thanks, Seshu
Updated•18 years ago
|
OS: Linux → All
Hardware: PC → All
Comment 4•18 years ago
|
||
My idea here was to include a smaller label centered below the current view's label (ie November) that would display an expanded string corresponding to the selected day. That would contain the year in it. Something like: --------------------------------------------------------------- |< September October November December January >| | | | Friday, 10 Nov 2006 | --------------------------------------------------------------- | | | | | | | | This would require adding a 'day-select' event that would be fired by the views whenever a new day was selected. Thoughts?
Comment 5•18 years ago
|
||
I'm afraid that this could take too much valuable height away. I'm on 1024x768 resolution and even with collapsed unifinder height already seems too little to me. Right now month (Jan-Dec), day(1-31) and weekday (mon-sun) are already visible from month view. Counter-proposal ;-) ---------------------------------------------------------------- |< September October November 2006 December January >| ---------------------------------------------------------------- | | | | | | | |
Comment 6•18 years ago
|
||
I kinda like Stefan's proposal, for the reason he cites.
Comment 7•18 years ago
|
||
Attachment #211744 -
Flags: first-review?(jminta)
Comment 8•18 years ago
|
||
Comment on attachment 211744 [details] [diff] [review] show year in month view (main nav label only) r=jminta, still looking for a good way to handle this in the other views.
Attachment #211744 -
Flags: first-review?(jminta) → first-review+
Comment 9•18 years ago
|
||
"show year in month view (main nav label only)" checked in. Leaving bug open for more work.
Comment 10•18 years ago
|
||
This patch uses formatDateShort() from calIDateTimeFormatter to view the date in depending on local format. This is fine for day view I think. But I'm not really sure about the week view.
Attachment #211747 -
Flags: first-review?(jminta)
Comment 11•18 years ago
|
||
Screenshot showing last patch in action.
Comment 12•18 years ago
|
||
Comment on attachment 211747 [details] [diff] [review] proposal for day/week view using calIDateTimeFormatter My concern for the week-view is for people with small-screen sizes. How small can you make that view before the labels run together? (or does our resizing not even allow that question to be answer?)
Comment 13•18 years ago
|
||
Comment on attachment 211747 [details] [diff] [review] proposal for day/week view using calIDateTimeFormatter Removing review request regarding last comment. The screenshot (attachment 211748 [details]) showed the week view in about the smallest window size I was able to achieve on my Windows system. If you make the window smaller the right day columns just disappear (no more resizing). (On Linux the navigation buttons above the header row prevent from making smaller before) This might call for different behaviour in day and week view. In day view we have enough space so we could even display the date in long format (as in old views). In week view we have to pay attention on space and need another solution. Another possibility that came into my mind during writing: Statusbar. Right now we don't use the statusbar in Sunbird. We could display the currently selected day there. I don't know if that could be done in Lightning too using the Thunderbird statusbar.
Attachment #211747 -
Flags: first-review?(jminta)
Comment 14•18 years ago
|
||
Reassigning all automatically assigned bugs from Mostafa to nobody@m.o Bugspam filter: TorontoMostafaMove
Assignee: mostafah → nobody
Comment 15•18 years ago
|
||
This is painful for view navigation. So much so that it's a blocker for 0.3.
Flags: blocking0.3+
Comment 16•18 years ago
|
||
Stefan, your patch has bitrotted a little bit. After applying it manually I get the following results: 1. If I startup Sunbird normally: The dates are correctly shown in DD/MM/YYYY mode, but once I switch to another day/week/month, the dates in the header box are switched back to MM/DD mode 2. If I startup Sunbird, while I'm subscribed to a remote calendar The correct date is shown (DD/MM/YYYY) for a very short period of time, but is switched back to the MM/DD mode once the remote calendar has been fully loaded
Comment 17•18 years ago
|
||
(In reply to comment #15) > This is painful for view navigation. So much so that it's a blocker for 0.3. At the moment we synchronize the view and the minimonth when navigating in the views. Therefore the selected day, month and year is always visible - as long as the minimonth sidebar is displayed. Therefore I think this isn't a real 0.3 blocker. (In reply to comment #16) > Stefan, your patch has bitrotted a little bit. That's life. This proposal isn't the best solution, because it takes up too much space in the header boxes. But I had another idea today: At the moment we display the [Rotate] button in the top left corner. There were some discussion to remove that button and make it e.g. a pref. Maybe we could use this empty place in the top left corner to display the date/year information?
Updated•18 years ago
|
Component: Sunbird Only → Calendar Views
QA Contact: sunbird → views
Updated•18 years ago
|
Whiteboard: [swag:0.5d][cal-ui-review needed]
Comment 18•18 years ago
|
||
Comment on attachment 211748 [details]
screenshot of week view
I think it is quite a bit of overkill to show the year (and month) seven times. One would be quite enough.
I think the big problem isn't the day header, but we should make the picker more intuitive. Most people don't think in week numbers. They might use it, but it's not the main thing you use to navigate. We should include the date in there.
Updated•18 years ago
|
Whiteboard: [swag:0.5d][cal-ui-review needed] → [swag:0.5d][cal-ui-review needed][possible l10n impact]
Updated•18 years ago
|
Flags: blocking0.3+ → blocking0.3-
Keywords: uiwanted
Whiteboard: [swag:0.5d][cal-ui-review needed][possible l10n impact] → [swag:0.5d][possible l10n impact]
Updated•18 years ago
|
Target Milestone: --- → Sunbird 0.5
Comment 19•18 years ago
|
||
This is a possible solution I was thinking of.
Comment 20•18 years ago
|
||
Note that unless we do some cool "month view vs. multiweek view" stuff, the proposal from attachment 243449 [details] does this to month view.
I think it adds a little more noise to the view than I'd like, but I'd like to hear others' opinions
Comment 21•17 years ago
|
||
Comment on attachment 243450 [details]
same proposal, but what it does to month view
Requesting ui-r to get some opinion/movement on this.
Attachment #243450 -
Flags: ui-review?(mvl)
Comment 22•17 years ago
|
||
Comment on attachment 243450 [details]
same proposal, but what it does to month view
ui-review=mvl
Attachment #243450 -
Flags: ui-review?(mvl) → ui-review+
Comment 24•16 years ago
|
||
This has been fixed by the work in Bug 444292. The view header now always includes the year of the displayed date range.
Status: NEW → RESOLVED
Closed: 16 years ago
Depends on: 444292
Resolution: --- → FIXED
Whiteboard: [swag:0.5d][possible l10n impact]
Target Milestone: --- → 0.9
Version: Trunk → unspecified
Comment 25•16 years ago
|
||
bug 444292 is verified, the jear is now visible in all calendar views -> this issue is VERIFIED, too.
Status: RESOLVED → VERIFIED
Updated•16 years ago
|
Assignee: nobody → Berend.Cornelius
You need to log in
before you can comment on or make changes to this bug.
Description
•