322060 - first (i.e. top-left) day should note current month, in multi-week view

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Calum Mackay]

Linux/x86, my build today from CVS.

In the old multi-week view, the first day shown, i.e the day at the top left, showed the month name as well as the day number.

In the new multi-week view, the top-left day has only the day number. The month numbers are only shown for the last and first days of a month, regardless of where they appear in the view.

For this reason I now find it much harder to "orientate" myself with this view, especially when changing dates via GoTo.

Any chance of restoring the month name on the top-left (and perhaps bottom-right) days in multi-week, in addition to the (existing) last and first days of a month, please?

Comment 1

[Joey Minta]

Attachment: patch for first box label

Patch adds a label to the first box in the multiweek view.  It's pretty trivial to add one to the bottom right as well, but that doesn't seem nearly as useful.  If others want it though, I can add it as well.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 210555 [details] [diff] [review]
patch for first box label

Won't it be much cleaner to tell the day boxes about their position, and then add the label code to the place where the other labels are generated, http://lxr.mozilla.org/seamonkey/source/calendar/base/content/calendar-month-view.xml#187 ?

Comment 3

[Joey Minta]

(In reply to comment #2)
> (From update of attachment 210555 [details] [diff] [review] [edit])
> Won't it be much cleaner to tell the day boxes about their position, and then
> add the label code to the place where the other labels are generated,
> http://lxr.mozilla.org/seamonkey/source/calendar/base/content/calendar-month-view.xml#187
> ?
> 

This would require that we also add the label in the month view, which I think would introduce clutter there (given that there are already 4 dates with month-labels).  I don't feel all that strongly about it, though, so if that's what everyone thinks is best, I can do that.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

We could create a attribute that can enable or disable the display of the monthname on the first item. Then we can disable it for the monthview, and enable for multiweek.

Comment 5

[Joey Minta]

Attachment: implement showFullMonth

This patch creates an attribute called showFullMonth.  It's used here to decide whether or not we label the first and last days of the view.  It can also be used to easily fix bug 321383.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 211506 [details] [diff] [review]
implement showFullMonth

>Index: calendar/base/content/calendar-decorated-multiweek-view.xml
>                     var viewElement = document.getAnonymousElementByAttribute(this, "anonid", "view-element");
>+                    viewElement.showFullMonth = false;
> 		    viewElement.tasksInView = this.mTasksInView;
Bonus points if you fix that tab :)

r=mvl

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

Before checking in, can you also fix this warning:

[JavaScript Warning: "function set_showMonthLabel does not always return a value" {file: "chrome://calendar/content/calendar-month-view.xml" line: 173 column: 20 source: "          return val;
"}]

Comment 8

[Joey Minta]

Patch checked in