322170 - Shockwave map doesn't appear on trunk

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Jesse Ruderman]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060102 Firefox/1.6a1

Steps to reproduce:
1. Go to http://darkwing.uoregon.edu/~atlas/europe/interactive/map32.html.

Result: no map.

Expected: map.

The Shockwave thingie on http://sdc.shockwave.com/shockwave/download/triggerpages_mmcom/default.html does work.

I only see this problem on trunk.  The page works on the Firefox 1.5.0.x branch (specifically, Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051224 Firefox/1.5.)

Comment 1

[Jesse Ruderman]

If I go directly to the plugin data URL (http://darkwing.uoregon.edu/~atlas/europe/interactive/map32.dcr), the trunk build does show the map.  So I don't think this is a problem of a server giving Firefox a bogus mime type.

Comment 2

[Jesse Ruderman]

This bug affects all of the "interactive" maps that http://darkwing.uoregon.edu/~atlas/europe/maps.html links to.

Comment 3

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051231 Firefox/1.6a1 ID:2005123103

I see the map but it uses 100% cpu. The same in IE.

Comment 4

[Jesse Ruderman]

Regressed between 2005-09-20 and 2005-09-22 trunk builds (Mac).  Bug 1156 went in during that period, so I'm guessing it's the culprit.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

ok. The html has:
<EMBED SRC="map32.dcr" height=350 width=465 PALETTE=background>

That file seems to be sent with application/x-director, which presumably is OK.

What does about:plugins show for this specific plugin, especially for the types and the extensions?

Comment 6

[Jesse Ruderman]

Shockwave for Director

    File name: NP-PPC-Dir-Shockwave
    Macromedia Shockwave for Director Netscape plug-in, version 10.1.0

MIME Type                Description          Suffixes        Enabled
application/x-director   Shockwave Movie      dcr,dir,dxr     Yes

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

a log shows:
-1610551960[2906c40]: OBJLC [25ae692c]: mFinalListener->OnStartRequest failed (80004005), falling back

(it also shows Got frame 249311c (mInstantiating=-1) - why minus 1?)

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

OK, turns out that the plugin's NPP_NewStream method returned NPERR_GENERIC_ERROR. sigh...

Comment 9

[Jesse Ruderman]

Attachment: Log with NSPR_LOG_MODULES=objlc:9,PluginNPN:9,PluginNPP:9,Plugin:9

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

(the build that produced this log contains the patch at http://stud4.tuwien.ac.at/~e0225227/callsetwindow.diff)

Comment 11

[Jesse Ruderman]

Attachment: log from an old 1.8 branch build in which the map works

Comment 12

[Jesse Ruderman]

Attachment: trunk log without that patch

Comment 13

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Regressions are bad :)

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Jesse, could you test this patch? I don't have easy access to a shockwave plugin right now.

Comment 15

[Jesse Ruderman]

I don't either -- I got my PowerBook replaced with a MacBook Pro last month and Shockwave is more or less unsupported on Intel Macs.

Comment 16

[Christian :Biesinger (don't email me, ping me on IRC)]

hm... what about windows? does this bug happen there too?

Comment 17

[Ryan VanderMeulen [:RyanVM]]

WFM on Windows

Comment 18

[Jesse Ruderman]

I can't get Shockwave to work at all on Windows, even at http://www.isketch.net/isketch.shtml.

Comment 19

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #17)
> WFM on Windows

Is that with or without the patch? (and if with the patch, was it broken without it?)

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Sorry, that's without the patch applied. Current trunk build, using Shockwave Player 10.1.

Comment 21

[Christian :Biesinger (don't email me, ping me on IRC)]

I can reproduce on windows/firefox/build from today

Comment 22

[Christian :Biesinger (don't email me, ping me on IRC)]

I actually can't, the reason it didn't work was that that build didn't find the plugin. once I fixed that, the page worked for me.

Comment 23

[Christian :Biesinger (don't email me, ping me on IRC)]

This problem is Mac-specific, and needs PPC because Shockwave for mac doesn't work on Intel.

This specific URL here works on trunk; I bet it was fixed by bug 347736, because we instantiate Shockwave directly without waiting for a server response, and then we don't fallback if NewStream returns an error.

Comment 24

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: workaround for shockwave/mac

Comment 25

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 274504 [details] [diff] [review]
workaround for shockwave/mac

actually this doesn't work

Comment 26

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: workaround for shockwave/mac, v2

Comment 27

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 274651 [details] [diff] [review]
workaround for shockwave/mac, v2

Gack.  I guess if we have to... :(

Comment 28

[Damon Sicore (:damons)]

Targeting for M8 per conversation with biesi.

Comment 29

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsObjectLoadingContent.cpp;
/cvsroot/mozilla/content/base/src/nsObjectLoadingContent.cpp,v  <--  nsObjectLoadingContent.cpp
new revision: 1.55; previous revision: 1.54
done