Closed Bug 322243 Opened 19 years ago Closed 17 years ago

Some elements in the card properties dialog missing accesskeys.

Categories

(MailNews Core :: Address Book, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vhaarr+bmo, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 3 obsolete files)

All the elements in the "Address" tab of the card property dialog are missing accesskeys, and so is the "Notes" textarea of the "Other"-tab.
Assignee: mail → nobody
Component: Address Book → MailNews: Address Book
Product: Mozilla Application Suite → Core
I have a WIP patch for this.

Any suggestions on what should be done for an access key for address line 2 which currently doesn't have a label displayed?
Assignee: nobody → bugzilla
Attached patch Partial patch (obsolete) — Splinter Review
This patch would probably fix the bug if bug 143065 was fixed. I'll mark this as a dependency in a mo.
Reassigning to default owner, I may pick this up again if bug 143065 gets fixed. Until then with ~31 fields needing access keys, we're stuck on this bug.
Assignee: bugzilla → nobody
Depends on: 143065
bug 143065 now fixed, I'll see if I can pick this up soon.
Assignee: nobody → bugzilla
Attached patch The fix (diff -w) (obsolete) — Splinter Review
Attachment #295643 - Flags: review?(neil)
Attached patch The fix (normal patch) (obsolete) — Splinter Review
Attachment #213239 - Attachment is obsolete: true
Comment on attachment 295643 [details] [diff] [review]
The fix (diff -w)

>         <groupbox flex="1">
>-          <caption label="&Notes.box;"/>
>-          <textbox id="Notes" multiline="true" wrap="virtual" flex="1"/>
>+          <caption label="&Notes.box;" accesskey="&Notes.accesskey;"/>
>+          <textbox id="Notes" accesskey="&Notes.accesskey;" multiline="true"
>+		   wrap="virtual" flex="1"/>
>         </groupbox>
This funny indent is because of the -w, right?
Repeating the accesskey looks fugly, and means you can't click on the label to activate the field. Try <caption><label for="Notes"/></caption> perhaps?

> <!ENTITY chooseAddressBook.accesskey     "A">
>+<!ENTITY Address.accesskey              "A">
Oops ;-) Did you not try the new card dialog?
Attachment #295643 - Flags: review?(neil) → review-
Fixes the access key conflicts, and also the notes label.
Attachment #295643 - Attachment is obsolete: true
Attachment #295644 - Attachment is obsolete: true
Attachment #295804 - Flags: review?(neil)
Comment on attachment 295804 [details] [diff] [review]
The fix v2 (diff -w)

It sucks that we have to use h for Other though :-\
Attachment #295804 - Flags: review?(neil) → review+
Attachment #295804 - Flags: superreview?(mscott)
Attachment #295804 - Flags: superreview?(mscott) → superreview+
Patch checked in -> fixed.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: