322245 - Missing accesskeys in pref pane

Status: RESOLVED WONTFIX

(Other Applications :: DOM Inspector, defect)

Description

[Vidar Haarr (not reading bugmail)]

[SeaMonkey]

All the elements in the DOM Inspector pref pane and these items in the main window:
 * "Inspect" button,
 * View-> All elements,
 * Search->Find Next,
are missing accesskeys.

Comment 1

[(no longer active)]

The parts related to the main window are being addressed in bug 398603.

Comment 2

[(no longer active)]

Attachment: Add the access keys

Add the access keys to the DOM Inspector prefs window.

Comment 3

[[e-mail]]

Comment on attachment 283681 [details] [diff] [review]
Add the access keys

>-              <label id="lbElBorderColor" value="&borderColor.label;"/>
>+              <label id="lbElBorderColor" value="&borderColor.label;" accesskey="&borderColor.accesskey;"/>
The access key will not be any use until the label is hooked up to its control.

>-              <label id="lbElBorderWidth" value="&borderWidth.label;" control="txfElBorderWidth"/>
>+              <label id="lbElBorderWidth" value="&borderWidth.label;" accesskey="&borderWidth.accesskey;"
>+                control="txfElBorderWidth"/>
These lines need to be wrapped better, this is your big chance to fix them!

> <!ENTITY borderWidth.label "Border Width">
>+<!ENTITY borderWidth.label "W">
Wrong entity name.

Comment 4

[(no longer active)]

Attachment: Add the access keys (v2)

(In reply to comment #3)
> (From update of attachment 283681 [details] [diff] [review])
> >-              <label id="lbElBorderColor" value="&borderColor.label;"/>
> >+              <label id="lbElBorderColor" value="&borderColor.label;" accesskey="&borderColor.accesskey;"/>
> The access key will not be any use until the label is hooked up to its control.

Fixed.

> >-              <label id="lbElBorderWidth" value="&borderWidth.label;" control="txfElBorderWidth"/>
> >+              <label id="lbElBorderWidth" value="&borderWidth.label;" accesskey="&borderWidth.accesskey;"
> >+                control="txfElBorderWidth"/>
> These lines need to be wrapped better, this is your big chance to fix them!

Hmmm, another take at this.  Is it better?  What about the wrappings on the rest of the lines?

> > <!ENTITY borderWidth.label "Border Width">
> >+<!ENTITY borderWidth.label "W">
> Wrong entity name.

Fixed.

Comment 5

[Robert Kaiser]

Erm, not sure if this is good timing, as SeaMonkey is completely rewriting pref panes atm, and this panel needs to be rewritten as well for SeaMonkey 2.
1) Is there a DOMI panel available that might already fit with the <prefpane> stuff?
2) Shouldn't we make this  be rewritten right now, rather than adding accesskeys now and rewriting the whole panel completely again within the next weeks?

Comment 6

[Shawn Wilsher :sdwilsh]

Hrm, I think the prefpane is not used in Firefox at all.  Is this correct?

Comment 7

[Robert Kaiser]

The pref pane in this style is surely not used in Firefox, as it's written for the old xpfe prefwindow. But I don't know if perhaps there is another implementation around that fits with the toolkit <prefwindow> stuff to which SeaMonkey is moving in bug 394522.
IMHO it doesn't make much sense to fix the xpfe-based thing here when we need to rework the pref panel for SeaMonkey2 anyways. 

Comment 8

[Shawn Wilsher :sdwilsh]

There is a bug somewhere to hookup the prefs UI in Firefox, and I guess that would happen there?

Will Seamonkey be shipping with the old xpfe stuff, or no?  If not, I'm inclined to WONTFIX this bug, and file a new one to convert it over (with these changes) and request blocking Seamonkey on that bug.

Comment 9

[Robert Kaiser]

The strategy you point out in the last paragraph sounds good to me, we won't be shipping the old xpfe prefwindow in any release from the 1.9 cycle, hopefully not even in Alpha.

Comment 10

[Shawn Wilsher :sdwilsh]

Morphing bug since patch didn't do anything with the main interface, and WONTFIXing per Comment 9.

I filed Bug 399031 for converting over to the new prefpane, with the comment that we need to make sure accesskeys are used properly.