32229 - nsIDocumentLoaderObserver not firing on reload

Status: VERIFIED FIXED

(Core :: Layout, defect, P1)

Description

[Doug Turner (:dougt)]

I have implemented a nsIDocumentLoaderObserver to perform actions
related to the security icon and alerts.  I have found that during a
Refresh, or going back in my history, OnStartURLLoad and OnStopURLLoad
are not firing.

Comment 1

[don]

Travis, is this your bug?

Comment 2

[travis]

Actually, this bug will probably go away when the webprogress interfaces are 
added and he changes his code to watch those.

Comment 3

[Doug Turner (:dougt)]

when will your new interfaces be live? 

Comment 4

[Doug Turner (:dougt)]

I need to make sure that this works in your new interface for both reloads, and 
history page transitions. 

Comment 5

[don]

Move to M16 for now ...

Comment 6

[Doug Turner (:dougt)]

this is a major problem!  I need some kind of status on this before blindly 
moving to m16.  Without this, someone can spoof a secure site.

Comment 7

[don]

Oh well, let them spoof away.  This WILL NOT slow down M15.  That's not what M15
is for.  We will hold M16 for this obviously.  Besides, Travis is at Internet
World this week and I have no-one else to fix it.  I want the tree opened back
up on Friday for M16 or we'll never make May 2nd.  Call me or send me email if
this is a problem.

Comment 8

[Doug Turner (:dougt)]

This is critically important that it gets fixed: the sooner the better.  based 
on don's assertions --> m16.

Comment 9

[travis]

nsIWebProgress Interfaces are actually sending information for starting and 
stopping of a load.  The change of a location can also be seen with the 
OnLocationChange message.

Comment 10

[Doug Turner (:dougt)]

what about  url loads?  This is what is not firing on the nsIDocuementLoader.

Comment 11

[travis]

What do you mean an url load? What other type of load are we talking about? 

Comment 12

[Doug Turner (:dougt)]

there are two type of notifications that I need from the doc loader.  The first 
notifications are for the Page: OnStartDocumentLoad and OnStopDocumentLoad.  The 
second are for the indivudual URL loads on that page.  I am interested in both.

Comment 13

[travis]

Ok, so the nsIWebProgress Interfaces are actually notifying of the top level 
loads that are occuring.  The child loads are I think wrong at this point.  The 
toplevel change of location is right.

Comment 14

[Doug Turner (:dougt)]

This is fixed.  Marking as such.

Comment 15

[Chris Petersen]

Marking verified based on reporter's comments.