322354 - libxul always links against X11

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Mark Mentovai]

libxul (XUL.framework) always links against libX11, even if a non-X11 widget toolkit is in use.  This is a problem when X11 is available on the system but is not the chosen toolkit.  On the Mac, X11 is optional, so a build host with X11 installed will produce output that will not launch on targets that do not have X11 installed.  There may be similar problems on Windows build hosts with sufficient X11 support.

Comment 1

[Mark Mentovai]

Attachment: Only link against X11 when an X widget toolkit is selected

Comment 2

[Benjamin Smedberg]

Comment on attachment 207495 [details] [diff] [review]
Only link against X11 when an X widget toolkit is selected

Please put this on all the branches.

Comment 3

[Mark Mentovai]

Fixed everywhere.

Comment 4

[Wan-Teh Chang]

*** Bug 323906 has been marked as a duplicate of this bug. ***

Comment 5

[Colin Barrett [:cbarrett]]

Seeing this when cross-compiling x86 to PPC, as per http://developer.mozilla.org/en/docs/Mac_OS_X_Universal_Binaries#Cross-Compilation.

Comment 6

[Colin Barrett [:cbarrett]]

checking for trouble comparing to zero near std::operator!=()... (cached) no
checking for LC_MESSAGES... (cached) yes
checking for pkg-config... (cached) /opt/local/bin/pkg-config
checking for gtk+-2.0 >= 1.3.7 gdk-x11-2.0 glib-2.0 gobject-2.0... Package gtk+-2.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `gtk+-2.0.pc' to the PKG_CONFIG_PATH environment variable No package 'gtk+-2.0' found Package gdk-x11-2.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `gdk-x11-2.0.pc' to the PKG_CONFIG_PATH environment variable No package 'gdk-x11-2.0' found
configure: error: Library requirements (gtk+-2.0 >= 1.3.7 gdk-x11-2.0 glib-2.0 gobject-2.0) not met; consider adjusting the PKG_CONFIG_PATH environment variable if your libraries are in a nonstandard prefix so pkg-config can find them.
*** Fix above errors and then restart with "make -f client.mk build"
make[1]: *** [configure] Error 1
make: *** [/Users/cbarrett/Projects/Mozilla/mozilla/obj-i386-apple-darwin8.8.2/Makefile] Error 2

Comment 7

[Benjamin Smedberg]

Colin, that's not the same bug. Please file a new bug for that issue.