322424 - Default disabled select border no longer matches enabled border

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Matthew Schultz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

The default disabled select border styling no longer matches the enabled border.  

Reproducible: Always

Actual Results:  
Default disabled select form field border does not match enabled select border.

Expected Results:  
Default disabled select form field border should match enabled select border.

Note: This is a regression.  The default disabled select form field style on Firefox 1.0 and Mozilla 1.7.12 displays the border correctly.  The disabled border should match the enabled border for select fields.  For a css comparison, it is the difference between a solid 1px border (the way it's supposed to show) and an inset 2px border (the way it is showing now)

Comment 1

[Matthew Schultz]

Attachment: Demonstrates default border style difference

Comment 2

[Ria Klaassen (not reading all bugmail)]

See Bug 204237

Comment 3

[Matthew Schultz]

How many times can this possibly regress?

Comment 4

[James Ross]

What's happening is that the native theming code is being turned off, either explicitly or indirectly though some application of CSS. The rather ugly 2px sunken border on the disabled one is the pure CSS style, rather than the native one.

Comment 5

[James Ross]

Looks like a copy-and-paste error at:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/widget/src/xpwidgets/nsNativeTheme.cpp&rev=1.26&mark=272-273#264

Just trying to see if that fixes it...

Comment 6

[James Ross]

Yup, easy fix. Rah! Patch in a sec...

Comment 7

[James Ross]

Attachment: Match against disabled BG colour

Ironically, this is a regression from the other bug mentioned (bug 204237). But it's a simple fix, and I'm pretty sure it was meant to be this to start with.

Comment 8

[[e-mail]]

Comment on attachment 222337 [details] [diff] [review]
Match against disabled BG colour

Looks good, by comparison with the NS_THEME_TEXTFIELD case.

Comment 9

[James Ross]

Comment on attachment 222337 [details] [diff] [review]
Match against disabled BG colour

I can't land this until Friday - someone else is free to check in before then.

This is needed on the 1.8 branch too, although the file is in a slightly different place:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/gfx/src/shared/nsNativeTheme.cpp&rev=1.22&mark=277#268

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 222337 [details] [diff] [review]
Match against disabled BG colour

The approval-branch-181 flag needs a requestee.

Comment 11

[James Ross]

Checked in --> FIXED.