322461 - [FIX]FF 1.5 doesn't apply CSS stylesheets in document after XSLT transformation

Status: RESOLVED FIXED

(Core :: XSLT, defect, P1)

Description

[Pavel Franc - Mozilla.cz]

FF 1.5 doesn't apply CSS rules with selector in uppercase in document after XSLT transformation with the output set to html.

Comment 1

[Pavel Franc - Mozilla.cz]

Attachment: Testcase

Comment 2

[Axel Hecht [:Pike]]

Attachment: result of the above as HTML

For reference, this is the output of the transform, as html.

Comment 3

[Ria Klaassen (not reading all bugmail)]

As result of the testcase of comment #1 the culprit must be in this list:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-04-18+08%3A00%3A00&maxdate=2005-04-19+06%3A00%3A00&cvsroot=%2Fcvsroot

Comment 4

[Axel Hecht]

Ria, could you explain that with a bit more detail? Did you test nightlies between
1.7 and 1.8?

Comment 5

[Martijn Wargers (dead)]

Yes, that's what she did.
From that regression range, I would think this could be a regression from bug 290068.

Comment 6

[Axel Hecht]

Seems like we're setting case sensitivity eagerly, too.

Comment 7

[Boris Zbarsky [:bzbarsky]]

So we call SetCaseSensitive() in the nsDocument Init() (and at this point we're assuming case-sensitive).  Then we reset it once we know whether we're HTML or XHTML, which is in nsHTMLDocument::StartDocumentLoad().  Of course XSLT doesn't call StartDocumentLoad(), right?

So how does XSLT actually create the document?  How is the document supposed to know it's an HTML document and not an XHTML one?

Comment 8

[Boris Zbarsky [:bzbarsky]]

OK, I see what's up.  The document is created via createInstance, which never initializes the mDefaultNamespaceID member of HTMLDocument.  That means the zeroing allocator sets it to 0, which happens to be kNamespaceID_None.  We should probably fix this part.

But anyway, it looks like creating by contract id gives us an HTML document, not an XHTML one.  So we should probably override Init() in nsHTMLDocument to call the superclass Init() and then reset the case-sensitivity as needed...

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Why bother setting mDefaultNamespace to kNameSpaceID_None (== 0)?

This is a pretty bad regression (one that we should test for when we get automated tests), would be good to get this on the branches.

Comment 11

[Boris Zbarsky [:bzbarsky]]

> Why bother setting mDefaultNamespace to kNameSpaceID_None (== 0)?

Because I think depending on kNameSpaceID_None == 0 is a bad idea.

Comment 12

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Good point

Comment 13

[Johnny Stenback (:jst)]

Comment on attachment 207628 [details] [diff] [review]
Fix

r+sr=jst

Comment 14

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 207628 [details] [diff] [review]
Fix

This is probably serious enough a regression to be worth considering for 1.8.0.x.  I definitely think we should take this for 1.8.1.

The patch is very very safe.  Only cases where the document is not actually being loaded (like XSLT) are affected.

Comment 15

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

how will this affect things like document.implementation.createDocument? I guess not very much since such documents are never styled?

Comment 16

[Boris Zbarsky [:bzbarsky]]

Fixed on trunk.

Sicking, createDocument creates the same thing after this patch as it always did.  But yes, those documents are never styled, at the moment.

Comment 17

[Axel Hecht]

createDocument only creates XML documents anyway.

Comment 18

[Daniel Veditz [:dveditz]]

Comment on attachment 207628 [details] [diff] [review]
Fix

This has come in too late for 1.8.0.1 (no trunk-baking time) but we'll consider for 1.8.0.2

Comment 19

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch merged to 1.8.x branch

Comment 20

[Boris Zbarsky [:bzbarsky]]

Fixed on the 1.8 branch.

Comment 21

[Daniel Veditz [:dveditz]]

Comment on attachment 208126 [details] [diff] [review]
Patch merged to 1.8.x branch

approved for 1.8.0 branch, a=dveditz

Comment 22

[Boris Zbarsky [:bzbarsky]]

Fixed for 1.8.0.2

Comment 23

[Dave Liebreich [:davel]]

Marking [rft-dl] (ready for testing in Firefox 1.5.0.2 release candidates)

Comment 24

[Jay Patel [:jay]]

v.fixed on 1.8.0 branch with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2, I see green.

Comment 25

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

*** Bug 315380 has been marked as a duplicate of this bug. ***

Comment 26

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

*** Bug 327902 has been marked as a duplicate of this bug. ***

Comment 27

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

*** Bug 340980 has been marked as a duplicate of this bug. ***

Comment 28

[Boris Zbarsky [:bzbarsky]]

Added to reftest.