322570 - Namespaces that are not used don't get registered

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Since bug 192139, when parsing XML we only call RegisterNamespace from SplitExpatName, so a namespace that's not actually used in the document doesn't get registered with the namespace manager.  This causes us to have a bug in lookupPrefix, as far as I can see.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yeah, this should be fixed in the lookupPrefix implementation

Comment 3

[Boris Zbarsky [:bzbarsky]]

So should ResolvePrefix just call RegisterNamespace on the string you pass in or something?  That seems a little suboptimal...

In general, it also looks like the namespace manager hashtables could balloon uncontrollably.  :(

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

The entire lookup is unneccesary. It seems like it was originally some sort of optimization to bail early, but it's obviously wrong. Patch comming up.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: This otta' do it

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 207773 [details] [diff] [review]
This otta' do it

Sure.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in