322600 - Bump up version to 1.1a on MOZILLA_1_8_BRANCH

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Ian Neal]

Now MOZILLA_1_8_0_BRANCH has been created the version off SeaMonkey on the 1.8 branch should be changed from 1.0b to 1.1a

Comment 1

[Ian Neal]

Attachment: Does the deed v0.1

Comment 2

[Robert Kaiser]

Comment on attachment 207758 [details] [diff] [review]
Does the deed v0.1

I know you didn't ask me for it, but as I did the last version changes, I guess I'm fitting :)

Please care to not insert a newline into version.txt - the rest looks fine to me.

Comment 3

[Ian Neal]

If I knew how to do that I would but even doing echo 1.1a > version.txt seems to add somesort of endofline marker.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

echo -n

But that said... this file really ought to work with an EOL sign.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Note that firefox does have a newline there:

$ xxd ~/mozilla/browser/config/version.txt
0000000: 312e 3661 310a                           1.6a1.

Comment 6

[Robert Kaiser]

biesi:
You just need to correctly change to configure.in line to exclude the newline then, IMO.
We surely don't want MOZ_APP_VERSION to contain the newline.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

I don't think so (even ignoring the fact that this works for ffox):
[15:25:53 chb@christian tmp]$ echo 1.1a > bar
[15:25:56 chb@christian tmp]$ export x=`cat bar`
[15:26:14 chb@christian tmp]$ env|grep ^x=
x=1.1a
[15:26:19 chb@christian tmp]$

No additional newline.

Comment 8

[Ian Neal]

So with or without new line then?
Other question is do we move to the same as FF and use 1,1a,0,0 instead of 1,1,0,0?

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #8)
> So with or without new line then?
> Other question is do we move to the same as FF and use 1,1a,0,0 instead of
> 1,1,0,0?

I would add the newline and go for 1,1a,0,0

Comment 10

[Ian Neal]

Attachment: Doing a slightly different deed v0.1a (Checked into branch 1.8)

As biesi suggests

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 207851 [details] [diff] [review]
Doing a slightly different deed v0.1a (Checked into branch 1.8)

r+a=me for MOZILLA_1_8_BRANCH

Comment 12

[Ian Neal]

Comment on attachment 207851 [details] [diff] [review]
Doing a slightly different deed v0.1a (Checked into branch 1.8)

Checking in (branch 1.8)
module.ver;
new revision: 1.4.2.2; previous revision: 1.4.2.1
version.txt;
new revision: 1.1.4.2; previous revision: 1.1.4.1
done