Closed
Bug 322620
Opened 19 years ago
Closed 19 years ago
Logging in with 'Remember my Login' deselected gives: Use of uninitialized value in string eq at Bugzilla/Auth/Login/WWW/CGI.pm line 83
Categories
(Bugzilla :: User Accounts, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.20
People
(Reporter: bugzilla-mozilla, Assigned: bugzilla-mozilla)
References
Details
Attachments
(1 file)
|
787 bytes,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
On 2.20 branch, but I see the same code in Bugzilla CVS.
To reproduce:
1. Change rememberlogin to defaulton or defaultoff
2. On the Bugzilla index.cgi, deselect 'Remember my login'
3. Enter login/password
The error_log shows:
index.cgi: Use of uninitialized value in string eq at Bugzilla/Auth/Login/WWW/CGI.pm line 83
Caused by:
> $cgi->param('Bugzilla_remember') eq 'on')
Patch follows.
|
Assignee | |
Comment 1•19 years ago
|
||
Against 2.20 branch, but applies with harmless offset warning to Bugzilla CVS.
Assignee: user-accounts → bugzilla-mozilla
Status: NEW → ASSIGNED
Attachment #207780 -
Flags: review?(LpSolit)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 207780 [details] [diff] [review]
Patch v1
r=LpSolit for 2.20 and tip
Attachment #207780 -
Flags: review?(LpSolit) → review+
|
|
||
Updated•19 years ago
|
Blocks: bz-warnings
Severity: normal → minor
Flags: approval?
Flags: approval2.20?
Target Milestone: --- → Bugzilla 2.20
|
||
Updated•19 years ago
|
Flags: approval?
Flags: approval2.20?
Flags: approval2.20+
Flags: approval+
|
|
||
Comment 3•19 years ago
|
||
tip:
Checking in Bugzilla/Auth/Login/WWW/CGI.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Login/WWW/CGI.pm,v <-- CGI.pm
new revision: 1.16; previous revision: 1.15
done
2.20:
Checking in Bugzilla/Auth/Login/WWW/CGI.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Login/WWW/CGI.pm,v <-- CGI.pm
new revision: 1.12.2.2; previous revision: 1.12.2.1
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•