322689 - ASSERTION: Wrapping frame should be block-level: 'aLastRS->frame->GetStyl

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase, Mozilla gives an assertion when loading the testcase:
###!!! ASSERTION: Wrapping frame should be block-level: 'aLastRS->frame->GetStyl
eDisplay()->IsBlockLevel()', file c:/mozilla/mozilla/layout/generic/nsBlockFrame
.cpp, line 610

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

This is fixed by the patch for bug 322348

Comment 3

[Boris Zbarsky [:bzbarsky]]

Er... no.  I was testing the wrong thing.  Ignore comment 2.

Comment 4

[Boris Zbarsky [:bzbarsky]]

This assert was introduced in bug 294934.  It seems to me that we want the "looks like a block from the inside" test here (the one we don't have yet).

Comment 5

[Jesse Ruderman]

Still happens on trunk.

Comment 6

[Boris Zbarsky [:bzbarsky]]

So the parent frame in this case is an nsHTMLButtonControlFrame.  I think this assert is basically bogus: all sorts of non-block things can contain a blockframe.

Comment 7

[Martijn Wargers (dead)]

Attachment: patch?

So the assertion can be removed?
Or you want a better assertion like you mentioned in comment 4?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 275485 [details] [diff] [review]
patch?

Yeah, I think this is the best we can do.

Comment 9

[Martijn Wargers (dead)]

Comment on attachment 275485 [details] [diff] [review]
patch?

Removal of a useless assertion.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 275485 [details] [diff] [review]
patch?

a1.9=dbaron

Comment 11

[Martijn Wargers (dead)]

Checking in nsBlockFrame.cpp;
/cvsroot/mozilla/layout/generic/nsBlockFrame.cpp,v  <--  nsBlockFrame.cpp
new revision: 3.856; previous revision: 3.855
done

Checked in.