322760 - connection settings pref window wrong text

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

The connection settings windows shows the following options:

Direct connection to the internet
Automatic proxy configuration URL:
Manual proxy configuration
Automatic proxy configuration URL:
 [TEXTBOX]

So option 2 and 4 have the same name and the same shortcut.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch

this patch introduces a new entity (the same as in Firefox) and removes an obsolete one.

Comment 2

[Simon Paquet [:sipaq]]

Comment on attachment 207911 [details] [diff] [review]
patch

Looks good.
r=sipaq

But since I'm not competent enough to be the only reviewer on Sunbird patches, I would like to have jminta look at this as well.

Comment 3

[Joey Minta]

Comment on attachment 207911 [details] [diff] [review]
patch

r=jminta, do you have checkin privs or should I land this myself?

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

I have checkin rights but I'm not sure how calendar is handling the branches.
(checkin to trunk and 1_8_BRANCH or only trunk?)

Comment 5

[Joey Minta]

(In reply to comment #4)
> I have checkin rights but I'm not sure how calendar is handling the branches.
> (checkin to trunk and 1_8_BRANCH or only trunk?)
> 

Yes, just the default options for the cross-commit tool.

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

checke¢ in on trunk and MOZILLA_1_8_BRANCH