Closed Bug 322760 Opened 14 years ago Closed 14 years ago

connection settings pref window wrong text

Categories

(Calendar :: Sunbird Only, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wolfiR, Assigned: wolfiR)

Details

Attachments

(1 file)

The connection settings windows shows the following options:

Direct connection to the internet
Automatic proxy configuration URL:
Manual proxy configuration
Automatic proxy configuration URL:
 [TEXTBOX]

So option 2 and 4 have the same name and the same shortcut.
Attached patch patchSplinter Review
this patch introduces a new entity (the same as in Firefox) and removes an obsolete one.
Assignee: mostafah → mozilla
Status: NEW → ASSIGNED
Attachment #207911 - Flags: first-review?(bugzilla)
Comment on attachment 207911 [details] [diff] [review]
patch

Looks good.
r=sipaq

But since I'm not competent enough to be the only reviewer on Sunbird patches, I would like to have jminta look at this as well.
Attachment #207911 - Flags: second-review?(jminta)
Attachment #207911 - Flags: first-review?(bugzilla)
Attachment #207911 - Flags: first-review+
Comment on attachment 207911 [details] [diff] [review]
patch

r=jminta, do you have checkin privs or should I land this myself?
Attachment #207911 - Flags: second-review?(jminta) → second-review+
I have checkin rights but I'm not sure how calendar is handling the branches.
(checkin to trunk and 1_8_BRANCH or only trunk?)
(In reply to comment #4)
> I have checkin rights but I'm not sure how calendar is handling the branches.
> (checkin to trunk and 1_8_BRANCH or only trunk?)
> 

Yes, just the default options for the cross-commit tool.
checke¢ in on trunk and MOZILLA_1_8_BRANCH
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.