Closed Bug 322828 Opened 19 years ago Closed 19 years ago

File upload widget 'Browse' button flickers when styled with font-size

Categories

(Camino Graveyard :: HTML Form Controls, defect)

Product:
Camino Graveyard
Component:
HTML Form Controls
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Camino1.0

People

(Reporter: matt, Assigned: moz)

References

Details

(Keywords: fixed1.8.0.2, fixed1.8.1, Whiteboard: [camino-1.0])

Attachments

(3 files, 1 obsolete file)

Minimal test case
85 bytes, text/html
Details
Better patch; font-size change only.
584 bytes, patch
alqahira
: review+
sfraser_bugs
: superreview+
jaas
: approval-branch-1.8.1+
dveditz
: approval1.8.0.2+
Details | Diff | Splinter Review
Testcase with disabled file input
158 bytes, text/html
Details
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051229 Camino/1.0b2 Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051229 Camino/1.0b2 When you try something like this: <input type="file" style="font-size: 100px;" size="1"/> and click on the big 'Browse...' button, it flickers between the big button and a standard-size small button behind it. Whether the click actually registers is a lottery depending on which button is showing when you release the click. Reproducible: Always Steps to Reproduce: 1. Create an HTML file containing the following: <html> <body> <input type="file" style="font-size: 100px;" size="1"/> </body> </html> 2. Click on the 'Browse...' button Actual Results: Button flickers weirdly Expected Results: Button doesn't flicker weirdly This is a bit of a show-stopper when trying to apply this hack: http://www.quirksmode.org/dom/inputfile.html on camino. Basically we want to pop up the select file dialog without displaying the whole file upload field, just a custom button of our own. This requires an ugly hack whereby the actual file upload button floats above it with opacity zero. I'm sure it's a pain for others trying to style these fields too.
Attached file Minimal test case —
Status: UNCONFIRMED → NEW
Ever confirmed: true
I'm tempted to dupe this to bug 205136 (since that's where bug 274348 was duped). Moreover, AIUI, the Gecko folks are leaning towards redoing that widget anyway, Safari-style.
This should fix it.
Assignee: mikepinkerton → mozilla
Status: NEW → ASSIGNED
Attachment #210008 - Flags: review?
Attachment #210008 - Flags: review? → review?(sfraser_bugs)
Hrm; actually, only the font-size: inherit; is necessary...
Attachment #210008 - Attachment is obsolete: true
Attachment #210013 - Flags: review?
Attachment #210008 - Flags: review?(sfraser_bugs)
Attachment #210013 - Flags: review? → review?(sfraser_bugs)
I think we should fix this for 1.0. I see it every time I use a file input.
Flags: camino1.0+
Target Milestone: --- → Camino1.0
We should make the font size styles consistent between disabled and non-disabled inputs.
(In reply to comment #7) > Created an attachment (id=210021) [edit] > Testcase with disabled file input > > We should make the font size styles consistent between disabled and > non-disabled inputs. Ignore: this was fixed post 1.0b2.
Attachment #210013 - Flags: superreview+
Attachment #210013 - Flags: review?(sfraser_bugs)
Attachment #210013 - Flags: review?(mark)
*** Bug 274348 has been marked as a duplicate of this bug. ***
Comment on attachment 210013 [details] [diff] [review] Better patch; font-size change only. mento, I hope you don't mind me stealing this review. I've tested this change, it fixes the problem, and doesn't cause any other issues in my testing. r=alqahira@mindspring.com Requesting approval for landing on the 1.8.0.x branch so we can get this in Camino 1.0. Drivers, this is a change to the Cocoa-only section of forms.css (which currently only affects Camino) that fixes an issue where the button on input[file] can change sizes when clicked.
Attachment #210013 - Flags: review?(mark)
Attachment #210013 - Flags: review+
Attachment #210013 - Flags: approval1.8.1?
Attachment #210013 - Flags: approval1.8.0.2?
Comment on attachment 210013 [details] [diff] [review] Better patch; font-size change only. Moving flag request to branch-1.8.1.
Attachment #210013 - Flags: approval1.8.1? → branch-1.8.1?
Attachment #210013 - Flags: branch-1.8.1? → branch-1.8.1+
Fixed on trunk, MOZILLA_1_8, and CAMINO_1_0.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [camino-1.0]
v on CAMINO_1_0_BRANCH and trunk.
Status: RESOLVED → VERIFIED
Comment on attachment 210013 [details] [diff] [review] Better patch; font-size change only. a=dveditz for 1.8.0 branch (cocoa only change)
Attachment #210013 - Flags: approval1.8.0.2? → approval1.8.0.2+
Fixed on MOZILLA_1_8_0_BRANCH.
Keywords: fixed1.8.0.2
*** Bug 327570 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: