322863 - Properly implement parsing of IMAP |atom| and |astring|

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Hans-Andreas Engel]

According to RFC 3501, the characters "()}%*\"" cannot be part of an |atom| or an |astring|.  This should be taken into account in |nsIMAPGenericParser|.

This would also fix the problem encountered in Bug 321239.

Comment 1

[Hans-Andreas Engel]

Attachment: Properly implement parsing of IMAP |atom| and |astring|, and be more specific when a parsing error is reported

For tracking down problems in IMAP protocol handling, it is helpful if the types of parsing errors are reported.  This patch also contains an implementation of such reporting.

Comment 2

[Hans-Andreas Engel]

I checked the corresponding implementation in pine4; it also uses a restricted character set when parsing atoms/astrings.

Comment 3

[David :Bienvenu]

OK, trying this out now, Thx,Hans.

Comment 4

[David :Bienvenu]

fixed on trunk. I'll land on the 1.8.1 branch if everything goes OK on the trunk. Thx, Hans. I also added you as a contributer to the two cpp files changed in your patch.

Comment 5

[Henrik Gemal]

after this patch I'm unable to read any IMAP messages due to:

S-INBOX.Barcelona:CreateNewLineFromSocket: * QUOTAROOT INBOX.Barcelona
S-INBOX.Barcelona:PARSER:Internal Syntax Error: %s:: no atom characters found
S-INBOX.Barcelona:PARSER:Internal Syntax Error on line: %s: * QUOTAROOT INBOX.Barcelona

I've opened bug 327754 on this issue

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #4)
> fixed on trunk. I'll land on the 1.8.1 branch if everything goes OK on the
> trunk. Thx, Hans. I also added you as a contributer to the two cpp files
> changed in your patch.

There's a regression in bug 327755 that I filed...

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Arg, Henrik and I collided.  I'll DUP my bug to his, no sweat.