code error in nsFontMetricsPango.cpp

RESOLVED FIXED

Status

Core Graveyard
GFX: Gtk
RESOLVED FIXED
12 years ago
9 years ago

People

(Reporter: Frederic Crozat, Assigned: roc)

Tracking

({fixed1.8.0.2, fixed1.8.1})

1.8 Branch
x86
Linux
fixed1.8.0.2, fixed1.8.1
Bug Flags:
blocking1.8.0.2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nvn-dl])

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
gcc detected a code error in nsFontMetricsPango.cpp (line 984) :

if (!found) {
  if (inx = 0) <<<<================ here
       retval = 0;
  else if (trailing)
          retval = aLength;

  goto loser;
}

It seems obvious test was replaced by assignment by mistake.

patch to fix this attached.

assigning to roc, after discussing with blizzard on irc
(Reporter)

Comment 1

12 years ago
Created attachment 208087 [details] [diff] [review]
trivial fix
Attachment #208087 - Flags: superreview+
Attachment #208087 - Flags: review+

Updated

12 years ago
Whiteboard: [checkin needed]
checked in. Thanks!
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Comment on attachment 208087 [details] [diff] [review]
trivial fix

This was reported against a branch, and would be nice to have fixed on the branch.
Attachment #208087 - Flags: approval1.8.0.2?
Attachment #208087 - Flags: approval-branch-1.8.1?
Comment on attachment 208087 [details] [diff] [review]
trivial fix

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #208087 - Flags: approval1.8.0.2?
Attachment #208087 - Flags: approval1.8.0.2+
Attachment #208087 - Flags: approval-branch-1.8.1?
Attachment #208087 - Flags: approval-branch-1.8.1+
Flags: blocking1.8.0.2+
checked in on branches
Keywords: fixed1.8.0.2, fixed1.8.1
Whiteboard: [checkin needed]
marking [nvn-dl], which removes this bug from the "to be verified by QA" list
for Firefox 1.5.0.2.
Whiteboard: [nvn-dl]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.