Closed
Bug 322928
Opened 19 years ago
Closed 19 years ago
code error in nsFontMetricsPango.cpp
Categories
(Core Graveyard :: GFX: Gtk, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fred, Assigned: roc)
Details
(Keywords: fixed1.8.0.2, fixed1.8.1, Whiteboard: [nvn-dl])
Attachments
(1 file)
391 bytes,
patch
|
roc
:
review+
roc
:
superreview+
dveditz
:
approval-branch-1.8.1+
dveditz
:
approval1.8.0.2+
|
Details | Diff | Splinter Review |
gcc detected a code error in nsFontMetricsPango.cpp (line 984) : if (!found) { if (inx = 0) <<<<================ here retval = 0; else if (trailing) retval = aLength; goto loser; } It seems obvious test was replaced by assignment by mistake. patch to fix this attached. assigning to roc, after discussing with blizzard on irc
Reporter | ||
Comment 1•19 years ago
|
||
Assignee | ||
Updated•19 years ago
|
Attachment #208087 -
Flags: superreview+
Attachment #208087 -
Flags: review+
Updated•19 years ago
|
Whiteboard: [checkin needed]
Assignee | ||
Comment 2•19 years ago
|
||
checked in. Thanks!
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 3•18 years ago
|
||
Comment on attachment 208087 [details] [diff] [review] trivial fix This was reported against a branch, and would be nice to have fixed on the branch.
Attachment #208087 -
Flags: approval1.8.0.2?
Attachment #208087 -
Flags: approval-branch-1.8.1?
Comment 4•18 years ago
|
||
Comment on attachment 208087 [details] [diff] [review] trivial fix approved for 1.8.0 branch, a=dveditz for drivers
Attachment #208087 -
Flags: approval1.8.0.2?
Attachment #208087 -
Flags: approval1.8.0.2+
Attachment #208087 -
Flags: approval-branch-1.8.1?
Attachment #208087 -
Flags: approval-branch-1.8.1+
Updated•18 years ago
|
Flags: blocking1.8.0.2+
Assignee | ||
Comment 5•18 years ago
|
||
checked in on branches
Keywords: fixed1.8.0.2,
fixed1.8.1
Whiteboard: [checkin needed]
Comment 6•18 years ago
|
||
marking [nvn-dl], which removes this bug from the "to be verified by QA" list for Firefox 1.5.0.2.
Whiteboard: [nvn-dl]
Updated•15 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•