322928 - code error in nsFontMetricsPango.cpp

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Frederic Crozat]

gcc detected a code error in nsFontMetricsPango.cpp (line 984) :

if (!found) {
  if (inx = 0) <<<<================ here
       retval = 0;
  else if (trailing)
          retval = aLength;

  goto loser;
}

It seems obvious test was replaced by assignment by mistake.

patch to fix this attached.

assigning to roc, after discussing with blizzard on irc

Comment 1

[Frederic Crozat]

Attachment: trivial fix

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in. Thanks!

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 208087 [details] [diff] [review]
trivial fix

This was reported against a branch, and would be nice to have fixed on the branch.

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 208087 [details] [diff] [review]
trivial fix

approved for 1.8.0 branch, a=dveditz for drivers

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in on branches

Comment 6

[Dave Liebreich [:davel]]

marking [nvn-dl], which removes this bug from the "to be verified by QA" list
for Firefox 1.5.0.2.