Closed Bug 322928 Opened 19 years ago Closed 19 years ago

code error in nsFontMetricsPango.cpp

Categories

(Core Graveyard :: GFX: Gtk, defect)

1.8 Branch
x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: fred, Assigned: roc)

Details

(Keywords: fixed1.8.0.2, fixed1.8.1, Whiteboard: [nvn-dl])

Attachments

(1 file)

gcc detected a code error in nsFontMetricsPango.cpp (line 984) :

if (!found) {
  if (inx = 0) <<<<================ here
       retval = 0;
  else if (trailing)
          retval = aLength;

  goto loser;
}

It seems obvious test was replaced by assignment by mistake.

patch to fix this attached.

assigning to roc, after discussing with blizzard on irc
Attached patch trivial fixSplinter Review
Whiteboard: [checkin needed]
checked in. Thanks!
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 208087 [details] [diff] [review]
trivial fix

This was reported against a branch, and would be nice to have fixed on the branch.
Attachment #208087 - Flags: approval1.8.0.2?
Attachment #208087 - Flags: approval-branch-1.8.1?
Comment on attachment 208087 [details] [diff] [review]
trivial fix

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #208087 - Flags: approval1.8.0.2?
Attachment #208087 - Flags: approval1.8.0.2+
Attachment #208087 - Flags: approval-branch-1.8.1?
Attachment #208087 - Flags: approval-branch-1.8.1+
Flags: blocking1.8.0.2+
checked in on branches
Whiteboard: [checkin needed]
marking [nvn-dl], which removes this bug from the "to be verified by QA" list
for Firefox 1.5.0.2.
Whiteboard: [nvn-dl]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: