322985 - Remove aScriptOnly parameter from the nsIEventListenerManager::RemoveAllListeners

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Noticed this while doing something else...atm aScriptOnly parameter is not used in
nsIEventListenerManager::RemoveAllListeners, it is always PR_FALSE. So I think it 
could be removed.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 208140 [details] [diff] [review]
proposed patch

Yeah, looks unused to me too. r+sr=jst

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Checking in content/events/public/nsIEventListenerManager.h;
/cvsroot/mozilla/content/events/public/nsIEventListenerManager.h,v  <--  nsIEventListenerManager.h
new revision: 1.41; previous revision: 1.40
done
Checking in content/events/src/nsEventListenerManager.cpp;
/cvsroot/mozilla/content/events/src/nsEventListenerManager.cpp,v  <--  nsEventListenerManager.cpp
new revision: 1.223; previous revision: 1.222
done
Checking in content/events/src/nsEventListenerManager.h;
/cvsroot/mozilla/content/events/src/nsEventListenerManager.h,v  <--  nsEventListenerManager.h
new revision: 1.82; previous revision: 1.81
done
Checking in dom/src/base/nsGlobalWindow.cpp;
/cvsroot/mozilla/dom/src/base/nsGlobalWindow.cpp,v  <--  nsGlobalWindow.cpp
new revision: 1.810; previous revision: 1.809
done

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed on MOZILLA_1_8_BRANCH by checkin of bug 336791.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Well, sort of; there's an unused parameter to Disconnect to preserve binary compatibility.  But this change basically had to be merged in (other than that difference) to land the things that landed on top of it.)