Closed
Bug 323010
Opened 19 years ago
Closed 19 years ago
nsSecretDecoderRing::SetWindow should be NS_IMETHODIMP, not nsresult
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla1.8.1
People
(Reporter: Waldo, Assigned: Waldo)
References
()
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
743 bytes,
patch
|
dveditz
:
review+
dveditz
:
superreview+
KaiE
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
This only matters on Windows, and it hasn't been a problem before because the nsISecretDecoderRingConfig interface isn't used in the source tree. Additionally, the single method on the interface doesn't do anything yet, so no one's made an attempt to use it.
http://lxr.mozilla.org/mozilla/search?string=nsisecretdecoderringconfig
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #208171 -
Flags: superreview?(dveditz)
Attachment #208171 -
Flags: review?(dveditz)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 208171 [details] [diff] [review]
Patch
r/sr=dveditz
Attachment #208171 -
Flags: superreview?(dveditz)
Attachment #208171 -
Flags: superreview+
Attachment #208171 -
Flags: review?(dveditz)
Attachment #208171 -
Flags: review+
|
||
Comment 3•19 years ago
|
||
mozilla/security/manager/ssl/src/nsSDR.cpp; new revision: 1.21;
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•19 years ago
|
Attachment #208171 -
Flags: branch-1.8.1+
|
|
||
Comment 4•19 years ago
|
||
Checked in on the 1.8 branch.
mozilla/security/manager/ssl/src/nsSDR.cpp; new revision: 1.20.2.1;
Keywords: fixed1.8.1
OS: Windows XP → All
Hardware: PC → All
Target Milestone: mozilla1.9alpha → mozilla1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•