Closed Bug 323040 Opened 19 years ago Closed 19 years ago

RTL <select>s have incorrect horizontal padding

Categories

(Core :: Layout: Form Controls, defect)

Product:
Core
Component:
Layout: Form Controls
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: uriber, Assigned: uriber)

Details

(Keywords: fixed1.8.1, rtl)

Attachments

(2 files)

patch
1.28 KB, patch
dbaron
: review+
dbaron
: superreview+
dbaron
: approval-branch-1.8.1+
Details | Diff | Splinter Review
screenshot
12.07 KB, image/png
Details 
The horizontal paddings inside <select> elements are currently specified in absolute terms (left vs. right). As a result, there is not enough right padding on the text in a closed "combobox" select (some letters are even partially obscured), and there is too much right padding on options in a "multiline" select.

Horizontal paddings should be specified using -moz-padding-start and -moz-padding-end.
Attached patch patch — — Splinter Review 

  

  


Assignee: nobody → uriber
Status: NEW → ASSIGNED

        Attachment #208198 -
        Flags: superreview?(dbaron)

        Attachment #208198 -
        Flags: review?(dbaron)

    
    

    
  

      
      
      
      

        Attached image
          
        screenshot
        — 
      

    


  
before (top) and after (bottom).

  

  



        Attachment #208198 -
        Flags: superreview?(dbaron)

        Attachment #208198 -
        Flags: superreview+

        Attachment #208198 -
        Flags: review?(dbaron)

        Attachment #208198 -
        Flags: review+

    
  

        Attachment #208198 -
        Flags: approval1.8.1?

    
    

    
  
Checked in:
Checking in layout/style/forms.css;
/cvsroot/mozilla/layout/style/forms.css,v  <--  forms.css
new revision: 3.112; previous revision: 3.111

  

  


Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha

    
  

        Attachment #208198 -
        Flags: approval1.8.1? → branch-1.8.1?(dbaron)

        Attachment #208198 -
        Flags: branch-1.8.1?(dbaron) → branch-1.8.1+

    
    

    
  
Checked in to 1.8.1 branch:
/cvsroot/mozilla/layout/style/forms.css,v  <--  forms.css
new revision: 3.104.4.5; previous revision: 3.104.4.4


  

  


Keywords: fixed1.8.1

    
    

    
  
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).

  

  


Keywords: rtl

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: