323105 - consider removing DeletingFrameSubtree

Status: RESOLVED DUPLICATE of bug 508473

(Core :: Layout, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think we should consider removing DeletingFrameSubtree, by doing the following:
 * change the rules so that out-of-flow frames are always destroyed through their placeholder, and things like nsAbsoluteContainingBlock and nsBlockFrame (for float list) just *assert* at the end of their Destroy that there are no out-of-flow frames left
 * make placeholder frame's destructor do UnregisterPlaceholderFrame
 * move the removal from primary frame map to the end of nsFrame::Destroy, and make it do something that checks to make sure it's removing the right frame
 * also do
     aFrame->RemovedAsPrimaryFrame(aPresContext);
     aFrameManager->ClearAllUndisplayedContentIn(content);
   somewhere in nsFrame::Destroy

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See also the cleanup in bug 310638.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I'll take this

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Making dependency go the other way around. It'll be easier to do this once mats patch is checked in.

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

DeletingFrameSubtree has been deleted in bug 508473 Part II, and our frame destruction mechanism should have been improved since then.