323265 - Disabled input type="image" has opaque/white background in Camino

Status: VERIFIED FIXED

(Camino Graveyard :: HTML Form Controls, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Spun off from bug 322890, which will just fix the input type="file" stuff via code.

Disabled input type="image" "buttons" have an opaque/white background in Camino; they should be transparent.

The testcase from bug 322890 is in the URL field above; Chris has a patch to our part of forms.css to fix this.

Comment 1

[Chris Lawson (gone)]

Attachment: sets background-color: transparent on disabled input images

Here's the patch, tested and ready for review/superreview/check-in.

cl

Comment 2

[Stuart Morgan]

Comment on attachment 208356 [details] [diff] [review]
sets background-color: transparent on disabled input images

Hard to argue with that. r=me

Comment 3

[Samuel Sidler (old account; do not CC)]

Comment on attachment 208356 [details] [diff] [review]
sets background-color: transparent on disabled input images

This is a cocoa-widget forms.css bug and affects Camino only.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Why only disabled ones?

Comment 5

[Stuart Morgan]

I'm pretty sure what's going in is this:
This core rule:

282 input[type="image"] {
...
286   background-color: transparent;

gives both transparent, but then there's this Cocoa rule:

551 input,
552 input[disabled] {
553   padding: 0px 1px 0px 1px;
554   font-size: 11px;
555   margin: 1px 1px 1px 1px;
556   background-color: -moz-field;

The |input| part isn't enough to override the transparent declaration, because it's less specific. |input[disabled]|, on the other hand, is equally specific and later in the file, so it trumps the transparancy (for disabled only).

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 208356 [details] [diff] [review]
sets background-color: transparent on disabled input images

1.8.0.1 is over

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This would be nice to get in 1.0 if we can get approval (as would bug 322890, which was moved to Core).

Comment 8

[Samuel Sidler (old account; do not CC)]

Comment on attachment 208356 [details] [diff] [review]
sets background-color: transparent on disabled input images

Moving flag request to branch-1.8.1.

Comment 9

[Mark Mentovai]

Fixed on trunk, MOZILLA_1_8, and CAMINO_1_0.

Comment 10

[Samuel Sidler (old account; do not CC)]

v. on CAMINO_1_0_BRANCH and trunk.

Comment 11

[Daniel Veditz [:dveditz]]

Comment on attachment 208356 [details] [diff] [review]
sets background-color: transparent on disabled input images

a=dveditz for 1.8.0 branch (cocoa only change)

Comment 12

[Mark Mentovai]

Fixed on MOZILLA_1_8_0_BRANCH.