chrome override URIs not resolved




13 years ago
2 years ago


(Reporter: chpe, Assigned: chpe)



Firefox Tracking Flags

(Not tracked)


(Whiteboard: [need testcase])


(1 attachment)

Following the chrome override example on :

override chrome://global/content/netError.xhtml jar:embedder.jar!/global/content/netError.xhtml

it looks like one should be able to specify a .jar file that resides in the same directory as the .manifest file and have that work without specifying an absolute path to the jar file; but it does not work as expected, since the override URI isn't resolved against the manifest's URI.

Simple patch follows.
Posted patch fixSplinter Review
I'm not sure how review works in this module; I've picked you from looking at the cvs log of recent checkins to nsChromeRegistry.cpp.
Attachment #208495 - Flags: first-review?(darin)

Comment 2

13 years ago
Hrm, I didn't really intend for it to be used this way (I typically meant it to be used as

override chrome://foo/content/url chrome://extension/content/override-file

But I guess this usecase makes some sense.


13 years ago
Attachment #208495 - Flags: first-review?(darin) → first-review+


13 years ago
Assignee: nobody → chpe
Do I need to request a second-review for the patch, or is first-review enough for checkin?
No, per you only need second-review when your first-reviewer thinks you do, and asks for it.

So, how bit-rotten have you gotten over the course of the last year?
The patch still applies cleanly:
patching file chrome/src/nsChromeRegistry.cpp
Hunk #1 succeeded at 2416 (offset 32 lines).


13 years ago
Whiteboard: [checkin needed]
chrome/src/nsChromeRegistry.cpp 1.349
Last Resolved: 13 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]

Comment 7

12 years ago
Comment on attachment 208495 [details] [diff] [review]

As far as I can tell, this is pretty low-risk, and it'd probably help extension developers to have this actually work on branch also.
Attachment #208495 - Flags: approval1.8.1.5?
Comment on attachment 208495 [details] [diff] [review]

approved for, a=dveditz for release-drivers
Attachment #208495 - Flags: approval1.8.1.5? → approval1.8.1.5+
Whiteboard: [checkin needed (1.8branch)]
chrome/src/nsChromeRegistry.cpp 1.338.2.5
Keywords: fixed1.8.1.5
Whiteboard: [checkin needed (1.8branch)]

Comment 10

12 years ago
Christian:  Any chance you can quickly verify this works in the latest 1.8 ( builds and replace the "fixed1.8.1.5" keyword with "verified1.8.1.5"?

Does anyone have a test case/extension that QA can use to verify this?
Whiteboard: [need testcase]
I ran into this problem in my embedding app (Epiphany), not in an extension. I don't have a 1.8 branch build, and the nightlies don't have the necessary stuff to build my app with it.

A testcase could be constructed with a file "myabout.xhtml" and the .manifest file in the same directory, containing:

override chrome://global/content/about.xhtml file:myabout.xhtml

and then visit the "about:" URL. Without the patch, you'll get a file-not-found error; with the patch you get shown your myabout.xhtml file.


11 years ago
Component: XRE Startup → Startup and Profile System
QA Contact: xre.startup → startup
You need to log in before you can comment on or make changes to this bug.