Closed Bug 323526 Opened 19 years ago Closed 19 years ago

Fix xpcom build break on OS/2 on 1.8 branches

Categories

(Core :: XPCOM, defect)

1.8 Branch
x86
OS/2
defect
Not set
blocker

Tracking

()

VERIFIED FIXED

People

(Reporter: mozilla, Assigned: mozilla)

Details

(Keywords: verified1.8.0.4, verified1.8.1)

Attachments

(1 file)

The XPCOM changes from bug 316732 and bug 316098 have now been checked in on the MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH. We need the corresponding OS/2 changes that were checked in without a bug on 2005-11-18:

2005-11-18 10:54 mkaply%us.ibm.com mozilla/xpcom/io/nsLocalFileOS2.cpp
2005-11-18 10:54 mkaply%us.ibm.com mozilla/xpcom/io/nsLocalFileOS2.h
2005-11-18 10:48 mkaply%us.ibm.com mozilla/xpcom/glue/standalone/nsGlueLinkingOS2.cpp
No, the patch from bug 316732 did not go in the branches, so we only need this patch for nsGlueLinkingOS2.cpp.

Would be nice if we had nightly builds for the 1.8 branch(es) on OS/2, too, to catch things like this earlier...
Assignee: dougt → mozilla
Status: NEW → ASSIGNED
Comment on attachment 208563 [details] [diff] [review]
patch to nsGlueLinkingOS2.cpp

lets have kaply r= this and with that, lets get it in.
Comment on attachment 208563 [details] [diff] [review]
patch to nsGlueLinkingOS2.cpp

r=mkaply

we do 1.8 nightlies...
Attachment #208563 - Flags: review+
Fix checked in to MOZILLA_1_8_BRANCH
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Thanks Mike. If you confirmed that it works it should probably also go on MOZILLA_1_8_0_BRANCH...

(Btw, if you do 1.8 nightlies, where are they uploaded.)
1.8.0 branch is completly closed to checkins right now. I'll check it in when it opens.

1.8 builds are here:

ftp://ftp.mozilla.org/pub/mozilla.org/seamonkey/nightly/contrib/latest-mozilla1.8
Comment on attachment 208563 [details] [diff] [review]
patch to nsGlueLinkingOS2.cpp

This OS/2 only change should really get into the 1.8.0 branch.
Attachment #208563 - Flags: approval1.8.0.3?
I thought I finally checked this in on the branch? I know it wasn't in the tags for 1502 and stuff.
Right, I forgot to check lxr. Adding the keyword.
Keywords: fixed1.8.0.3
Attachment #208563 - Flags: approval1.8.0.3?
Verified by code inspection.
Status: RESOLVED → VERIFIED
fixed1.8.1 based on comment 4
Keywords: fixed1.8.1
Verifying some older bugs.

(It's definitely fixed on 1.8 branch, too.)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: