323532 - [FIX] Leak when using history autocomplete

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD:  Current Firefox trunk build

STEPS TO REPRODUCE:

1) Start up Firefox
2) Click in URL field
3) Hit Alt+down to open history autocomplete

ACTUAL RESULTS: leak morkobjects

EXPECTED RESULTS: no leaks

This is going to be a safe fix that I'd suggest for 1.8.0.x branch, I think.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch for real

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 208574 [details] [diff] [review]
Patch for real

This is a very safe and simple leak fix.  We leak a few hundred bytes any time autocomplete happens and there are matches.

Comment 4

[Benjamin Smedberg]

Comment on attachment 208574 [details] [diff] [review]
Patch for real

This code is going away with places, no need for it on the 1.8 branch.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 208574 [details] [diff] [review]
Patch for real

approved for 1.8.0 branch, a=dveditz

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed for 1.8.0.2.

Comment 7

[Dave Liebreich [:davel]]

marking [nvn-dl], which removes this bug from the "to be verified by QA" list
for Firefox 1.5.0.2.  I'm not sure what we should do to verify leak fixes individually.  I'm open to suggestions

Comment 8

[Anbo Motohiko]

(In reply to comment #4)
> (From update of attachment 208574 [details] [diff] [review] [edit])
> This code is going away with places, no need for it on the 1.8 branch.
> 
"Places" has been disabled on the 1.8 branch. Do we need this?

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 208574 [details] [diff] [review]
Patch for real

Yes, I think so.

Comment 10

[Benjamin Smedberg]

Comment on attachment 208574 [details] [diff] [review]
Patch for real

How did this land on 1.8.0 but not 1.8?

Comment 11

[Boris Zbarsky [:bzbarsky]]

Benjamin, comment 4 explains how that happened.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Fixed on 1.8 branch, but I wish this had gotten approved when I asked for it initially; the marging was a little painful.  :(