Closed Bug 323539 Opened 15 years ago Closed 15 years ago

JS warning opening MailNews / selecting folders

Categories

(SeaMonkey :: MailNews: Message Display, defect)

1.8 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

(4 keywords)

Attachments

(1 file)

Opening MailNews produces a  warning in the JS console, same warning occurs everytime you select a folder in the folder pane:

"Warning: reference to undefined property nsMsgViewType.eSearch
Source File: chrome://messenger/content/commandglue.js
Line: 684"

This does not happen on trunk builds.

Karsten/Neil, iirc you know about this (and the cause)? Dupe away if this is already filed ;)
I forgot the review comment to bug 241212 when checking into the branches :-[
Depends on: 241212
Attached patch 1.8.0 patchSplinter Review
OK, this should fix the warning (eSearch --> eShowSearch).
Assignee: mail → stefanh
Status: NEW → ASSIGNED
Attachment #208580 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #208580 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 208580 [details] [diff] [review]
1.8.0 patch

Although seeing as I did get it right on the trunk I should be able to check this in on the branches with the original r/sr/as.
Attachment #208580 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #208580 - Flags: superreview+
Attachment #208580 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #208580 - Flags: review+
Blocks: 323357
Don't forget this can go on the 1.8 branch as well Stefan.
Attachment #208580 - Flags: approval-seamonkey1.1+
(In reply to comment #4)
> Don't forget this can go on the 1.8 branch as well Stefan.

I think Neil ment that the patch already has approval on both branches, since the original patch was approved.
Fix checked in on both branches. Do we need flags for this?
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
adding chunks of flaggy goodness
Whiteboard: fixed-seamonkey1.0
Whiteboard: fixed-seamonkey1.0
You need to log in before you can comment on or make changes to this bug.