323671 - must link to pangox

Status: RESOLVED INCOMPLETE

(Core :: Graphics, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

On my debian system, a cairo-gtk2+pango build fails to start up:
$ ./seamonkey
./seamonkey-bin: symbol lookup error: /home/chb/builds/cairo/dist/bin/components/libgkgfxthebes.so: undefined symbol: pango_x_font_map_for_display

That seems to be part of libpangox, and gecko does not link against that.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Hideo Oshima]

Is this related to bug 305185?

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

I don't think so...

Comment 4

[Benjamin Smedberg]

Comment on attachment 208671 [details] [diff] [review]
patch

I have no clue what this affects; let's try somebody who knows what pangox is.

Comment 5

[Wolfgang Rosenauer [:wolfiR]]

(In reply to comment #3)
> I don't think so...

I think it is the same cause as in bug 305185. pangox was exported by the gtk ldflags in older versions AFAIK.
https://bugzilla.mozilla.org/show_bug.cgi?id=305185#c1

This patch would be needed for gtk >= 2.7 IMHO but maybe still miss something
what is catched in bug 305185.
I would r+ this as first step but still consider the other patch more complete.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

oh. I only looked at the bug itself, not at the patch. the patch there is indeed more complete, although the code seems to have changed since that patch has been made...

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 325720 has been marked as a duplicate of this bug. ***

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 208671 [details] [diff] [review]
patch

clearing requests, let's use the patch from the other bug

Comment 9

[Jory A. Pratt [:anarchy]]

Index: configure.in
===================================================================
RCS file: /cvsroot/mozilla/configure.in,v
retrieving revision 1.1584
diff -p -u -6 -r1.1584 configure.in
--- configure.in	10 Jan 2006 23:32:12 -0000	1.1584
+++ configure.in	16 Jan 2006 22:27:29 -0000
@@ -4516,24 +4524,24 @@ MOZ_ARG_ENABLE_BOOL(pango,
     MOZ_ENABLE_PANGO=1,
     MOZ_ENABLE_PANGO=)
 
 if test "$MOZ_ENABLE_PANGO" && test -z "$MOZ_ENABLE_CAIRO_GFX"
 then
     AC_DEFINE(MOZ_ENABLE_PANGO)
-    PKG_CHECK_MODULES(MOZ_PANGO, pango >= 1.6.0 pangoft2 >= 1.6.0)
+    PKG_CHECK_MODULES(MOZ_PANGO, pango >= 1.6.0 pangoft2 >= 1.6.0 pangox >= 1.6.0)
 
     AC_SUBST(MOZ_ENABLE_PANGO)
     AC_SUBST(MOZ_PANGO_CFLAGS)
     AC_SUBST(MOZ_PANGO_LIBS)
 fi
 
 if test "$MOZ_ENABLE_PANGO" && test "$MOZ_ENABLE_CAIRO_GFX"
 then
     AC_DEFINE(MOZ_ENABLE_PANGO)
     dnl PKG_CHECK_MODULES(MOZ_PANGO, pango >= 1.10.0 pangocairo >= 1.10.0)
-    PKG_CHECK_MODULES(MOZ_PANGO, pango >= 1.6.0 pangoft2 >= 1.6.0 pangoxft >= 1.6.0)
+    PKG_CHECK_MODULES(MOZ_PANGO, pango >= 1.6.0 pangoft2 >= 1.6.0 pangoxft >= 1.6.0 pangox >= 1.6.0)
 
     AC_SUBST(MOZ_ENABLE_PANGO)
     AC_SUBST(MOZ_PANGO_CFLAGS)
     AC_SUBST(MOZ_PANGO_LIBS)
 fi


this is a bit extreme!!
Something along the lines of 
PKG_CHECK_MODULES(MOZ_PANGO,  pangox >= 1.6.0)
is all that is needed as pangox pkg-config will already have required on other spec files.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

why is that extreme? If the code uses functions from all of those modules, it should IMO check for all of them.

Comment 11

[Walter Meinl]

(In reply to comment #8)
> (From update of attachment 208671 [details] [diff] [review] [edit])
> clearing requests, let's use the patch from the other bug
> 

Biesi, the other bug305185 was resolved as a duplicate of bug338446 that in turn was now checked into the trunk and the branch . If linking against libpangox is still an issue for you now, you may reconsider if your patch is needed, cause bug338446 checks only for pangoxft and not for pangox. 

Comment 12

[Joe Drew (not getting mail)]

If this bug is still necessary, please reopen.