323731 - Remove Publishing page from Sunbird options dialog

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Stefan Sitter [:ssitter]]

Follow up of Bug 323180.

As we now store the used publishing url separate for each calendar, there is no need for the 'default remote filename' preference. This should be removed from the publishing code. (By the way this preference did not work at all).

As this preference is the only content of the Publishing page in the Sunbird options dialog we should also remove that page.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: patch

- Removing Publish page from the several options dialogs
- Removing corresponding xul file from jar
- Removing corresponding style rules
- Fix Id's for the Alarm page

Refering to Bug 323180 Comment #4 From Joey Minta about gPublishObject = new Object(); in loadCalendarPublishDialog():
This is still needed because publishCalendarData() in publish.js calls the dialog without passing a publishObject in. gPublishObject is later used in onOKCommand() to pass the remote file url to the caller.

Comment 2

[Joey Minta]

Comment on attachment 208892 [details] [diff] [review]
patch

Looks good.  Can you kill the l10n entities too, so that the localizers don't do work that isn't necessary?
http://landfill.mozilla.org/mxr-test/mozilla/source/calendar/resources/locale/en-US/prefs.dtd#147

r=jminta with that

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: patch, v2

Updated patch according to comment #2.

Comment 4

[Joey Minta]

patch checked in.