323765 - Thread unsafe VarPrefix from jsopcode.c

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Igor Bukanov]

The current code for VarPrefix in jsopcode.c thread-unsafe as it use shared static buffer for temporary strings without any locking.

Comment 1

[Igor Bukanov]

Attachment: Fix

The patch just uses explicit "const " and "var " strings without re-using js_var_str and js_const_str.

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 208736 [details] [diff] [review]
Fix

r=me, thanks!

/be

Comment 3

[Igor Bukanov]

I committed this on 2006-01-18.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

There's a blocking1.8.1? nomination on this bug.  Should it be landed for 1.8.1?

Comment 5

[Bob Clary [:bc] (inactive)]

(In reply to comment #4)
> There's a blocking1.8.1? nomination on this bug.  Should it be landed for
> 1.8.1?
> 

I guess that depends on if it gets approved for 1.8.1. I nominated it since was supposed to be in Spidermonkey 1.6 and I wanted Spidermonkey 1.6 and the 1.8.1 branch to have as much similarity as possible.

Comment 6

[Igor Bukanov]

Comment on attachment 208736 [details] [diff] [review]
Fix

The patch applies as-is to 1.8.* branches

Comment 7

[Igor Bukanov]

I committed the patch from comment 1 to MOZILLA_1_8_BRANCH

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 208736 [details] [diff] [review]
Fix

approved for 1.8.0 branch, a=dveditz for drivers

Comment 9

[Igor Bukanov]

I committed the patch from comment 1 to MOZILLA_1_8_0_BRANCH