Thread unsafe VarPrefix from jsopcode.c

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Igor Bukanov, Assigned: Igor Bukanov)

Tracking

({fixed1.8.0.7, fixed1.8.1})

Trunk
fixed1.8.0.7, fixed1.8.1
Points:
---
Bug Flags:
blocking1.8.1 +
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Fix
705 bytes, patch
brendan
: review+
Mike Schroepfer
: approval1.8.1+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
The current code for VarPrefix in jsopcode.c thread-unsafe as it use shared static buffer for temporary strings without any locking.
(Assignee)

Comment 1

12 years ago
Created attachment 208736 [details] [diff] [review]
Fix

The patch just uses explicit "const " and "var " strings without re-using js_var_str and js_const_str.
Assignee: general → igor.bukanov
Status: NEW → ASSIGNED
Attachment #208736 - Flags: review?(brendan)
Comment on attachment 208736 [details] [diff] [review]
Fix

r=me, thanks!

/be
Attachment #208736 - Flags: review?(brendan) → review+

Updated

12 years ago
Blocks: 309169
(Assignee)

Comment 3

12 years ago
I committed this on 2006-01-18.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Flags: testcase-

Updated

12 years ago
Flags: blocking1.8.1?
There's a blocking1.8.1? nomination on this bug.  Should it be landed for 1.8.1?

Comment 5

11 years ago
(In reply to comment #4)
> There's a blocking1.8.1? nomination on this bug.  Should it be landed for
> 1.8.1?
> 

I guess that depends on if it gets approved for 1.8.1. I nominated it since was supposed to be in Spidermonkey 1.6 and I wanted Spidermonkey 1.6 and the 1.8.1 branch to have as much similarity as possible.

Updated

11 years ago
Flags: blocking1.8.1? → blocking1.8.1+
(Assignee)

Comment 6

11 years ago
Comment on attachment 208736 [details] [diff] [review]
Fix

The patch applies as-is to 1.8.* branches
Attachment #208736 - Flags: approval1.8.1?
Attachment #208736 - Flags: approval1.8.0.6?

Updated

11 years ago
Attachment #208736 - Flags: approval1.8.1? → approval1.8.1+

Updated

11 years ago
Whiteboard: [checkin needed]
(Assignee)

Comment 7

11 years ago
I committed the patch from comment 1 to MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
Whiteboard: [checkin needed]
Comment on attachment 208736 [details] [diff] [review]
Fix

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #208736 - Flags: approval1.8.0.7? → approval1.8.0.7+
(Assignee)

Comment 9

11 years ago
I committed the patch from comment 1 to MOZILLA_1_8_0_BRANCH
Keywords: fixed1.8.0.7
You need to log in before you can comment on or make changes to this bug.