Closed
Bug 323765
Opened 19 years ago
Closed 19 years ago
Thread unsafe VarPrefix from jsopcode.c
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: igor, Assigned: igor)
References
Details
(Keywords: fixed1.8.0.7, fixed1.8.1)
Attachments
(1 file)
705 bytes,
patch
|
brendan
:
review+
dveditz
:
approval1.8.0.7+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
The current code for VarPrefix in jsopcode.c thread-unsafe as it use shared static buffer for temporary strings without any locking.
Assignee | ||
Comment 1•19 years ago
|
||
The patch just uses explicit "const " and "var " strings without re-using js_var_str and js_const_str.
Comment 2•19 years ago
|
||
Comment on attachment 208736 [details] [diff] [review] Fix r=me, thanks! /be
Attachment #208736 -
Flags: review?(brendan) → review+
Assignee | ||
Comment 3•19 years ago
|
||
I committed this on 2006-01-18.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•19 years ago
|
Flags: testcase-
Updated•18 years ago
|
Flags: blocking1.8.1?
There's a blocking1.8.1? nomination on this bug. Should it be landed for 1.8.1?
Comment 5•18 years ago
|
||
(In reply to comment #4) > There's a blocking1.8.1? nomination on this bug. Should it be landed for > 1.8.1? > I guess that depends on if it gets approved for 1.8.1. I nominated it since was supposed to be in Spidermonkey 1.6 and I wanted Spidermonkey 1.6 and the 1.8.1 branch to have as much similarity as possible.
Updated•18 years ago
|
Flags: blocking1.8.1? → blocking1.8.1+
Assignee | ||
Comment 6•18 years ago
|
||
Comment on attachment 208736 [details] [diff] [review] Fix The patch applies as-is to 1.8.* branches
Attachment #208736 -
Flags: approval1.8.1?
Attachment #208736 -
Flags: approval1.8.0.6?
Updated•18 years ago
|
Attachment #208736 -
Flags: approval1.8.1? → approval1.8.1+
Updated•18 years ago
|
Whiteboard: [checkin needed]
Assignee | ||
Comment 7•18 years ago
|
||
I committed the patch from comment 1 to MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
Whiteboard: [checkin needed]
Comment 8•18 years ago
|
||
Comment on attachment 208736 [details] [diff] [review] Fix approved for 1.8.0 branch, a=dveditz for drivers
Attachment #208736 -
Flags: approval1.8.0.7? → approval1.8.0.7+
Assignee | ||
Comment 9•18 years ago
|
||
I committed the patch from comment 1 to MOZILLA_1_8_0_BRANCH
Keywords: fixed1.8.0.7
You need to log in
before you can comment on or make changes to this bug.
Description
•