Closed Bug 323964 Opened 20 years ago Closed 20 years ago

DPI preference has different meaning on OS/2 than other platforms

Categories

(Core Graveyard :: GFX: OS/2, defect)

x86
OS/2
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: fixed1.8.1, Whiteboard: [patch])

Attachments

(1 file)

Negative values of the DPI preference have a different meaning on OS/2 than on other platforms. Elsewhere (where it's implemented), they mean to use the larger of 96dpi and what the system reports. This is a good thing, since some Web pages have (pt-sized) fonts that become illegibly small when the DPI gets less than 96dpi.
Attached patch patchSplinter Review
This reorders the if-else chain and changes one of the conditions to change the results for the case of value<0 and OSDPI > 96. Note that the pref default change simply mirrors bug 233082.
Attachment #208928 - Flags: superreview?(roc)
Attachment #208928 - Flags: review?(mozilla)
Comment on attachment 208928 [details] [diff] [review] patch r=mkaply
Attachment #208928 - Flags: review?(mozilla) → review+
Attachment #208928 - Flags: superreview?(roc) → superreview+
Checked in to trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Attachment #208928 - Flags: approval1.8.1? → branch-1.8.1?(roc)
Attachment #208928 - Flags: approval-branch-1.8.1?(roc) → approval-branch-1.8.1+
Checked in to MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: