3240 - Link border colors around images

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think link border colors that are drawn around images should change with the
link color, unless they are explicitly specified differently.

This can be done easily in ua.css, since border-color, if not specified,
"inherits" from color.  Thus you could change the four a:link img, a:visited
img, etc. from (for the a:link img example)

border: 2px solid blue;

to

border-width: 2px;
border-style: solid;

and leave the color to "inherit" from color.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

You could actually just set

border: 2px solid

now that I remember the shorthand property doesn't need all parts...

Comment 2

[Peter Linss]

Thanks, good catch!

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Verified fixed.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Reopening bug.  This is still a problem for a:visited, a:active, and a:out-of-
date (although I think it was once fixed).

Comment 5

[Peter Linss]

The problem is that the style changes aren't causing child frames to redraw
outside the frame of the parent, so the image border only updates inside the
line frame. This was exposed either by improvements in targeting style changes
or changes to line height calculations.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Are you talking about bug 5407 rather than this one?

Comment 7

[Peter Linss]

No, I was talking about the behavior I saw on this one. This works for me except
for the repaint issue. I'm closing this as a dup of 5407 now.

*** This bug has been marked as a duplicate of 5407 ***

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

As I said when I reopened it, it is fixed for a:link.  However, it is not fixed
for a:active.  I can tell this in two ways:

1) Going to the above URL, and clicking and holding down the mouse over the
image.  The bottom bit of the border turns lime.  It should be the same shade
of green as it is with the mouse out of the area, since the test page
sets :active to green.

2) Reading ua.css, which is how I found the problem in the first place (both
times).  This shows that it is a problem still for :active, :visited, and :out-
of-date (the latter two are not hooked up yet).

Thus you should change the following lines in ua.css from:

213 a:visited img {
214   display: inline;
215   border: 2px solid purple;
216   text-decoration: none;
217 }
218 a:active img {
219   display: inline;
220   border: 2px solid lime;
221   text-decoration: none;
222 }
223 a:out-of-date img {
224   display: inline;
225   border: 2px solid red;
226   text-decoration: none;

to:

213 a:visited img {
214   display: inline;
!215   border: 2px solid;
216   text-decoration: none;
217 }
218 a:active img {
219   display: inline;
!220   border: 2px solid;
221   text-decoration: none;
222 }
223 a:out-of-date img {
224   display: inline;
!225   border: 2px solid;
226   text-decoration: none;

Reopening bug again.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Verified fixed.