324137 - invalid command line options when simply ignored causes improper startup

Status: RESOLVED WONTFIX

(Toolkit :: Startup and Profile System, defect)

Description

[jon labadie]

User-Agent:       Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.8) Gecko/20051130 Firefox/1.5
Build Identifier: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.8) Gecko/20051130 Firefox/1.5

Observed in 1.5 version, not in earlier versions.
Observed in both Windows XP build and contributed Solaris x86 build.

I start firefox from a script that dates back to before firebird.  This caused some options I use in the script to no longer be valid for the browser.  The invalid options were silently ignored and caused no difficulty until version 1.5.

Specifically if my command line is "firefox -turbo -geometry 1200x1200", the last argument 1200x1200 is interpreted as my desired destination and causes an "I'm feeling lucky" google search for 1200x1200.

The option "-turbo" may still be valid for Windows systems, I don't think it does anything for Solaris systems.  "-geometry" was the way to specify the initial window size by passing the option on to the X window system.  It seems to no longer be used this way and thus should be considered invalid.  But I see no error messages that would have alerted me to these problems.


Reproducible: Always

Steps to Reproduce:
1.run "firefox -turbo -geometry 1200x1200"
2.
3.

Actual Results:  
Startup page is not the prefered "home page" but a webpage at shopping.msn.com

Expected Results:  
As a minimum, report the invalid options to the user

Comment 1

[Benjamin Smedberg]

http://lxr.mozilla.org/mozilla/source/browser/components/nsBrowserContentHandler.js#536

I don't think I want to emulate any more odd/old command-line handling behaviors.

Although I'm surprised that gtk_init doesn't deal with the -geometry flag.

Comment 2

[jon labadie]

What I was suggesting was not to emulate odd or old behavior.

Instead, simply note the presence of invalid command line args on standard error.

Comment 3

[Johan Vromans]

> Although I'm surprised that gtk_init doesn't deal with the -geometry flag.

I think the mozilla organisation is important enough to put a lot of pressure on the gtk organisation to solve this.