Closed Bug 324182 Opened 19 years ago Closed 19 years ago

Userdefined tags can lose one of their attributes

Categories

(Core :: DOM: HTML Parser, defect, P4)

Product:
Core
Component:
DOM: HTML Parser
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: mrbkap, Assigned: mrbkap)

References

(
URL
)

Details

(Whiteboard: [patch])

Attachments

(2 files, 2 obsolete files)

Cleanup
4.50 KB, patch
sicking
: review+
jst
: superreview+
Details | Diff | Splinter Review
Cleanup -w
3.69 KB, patch
Details | Diff | Splinter Review
Userdefined tags get a special __moz-userdefined attributed pushed onto them so that editor can easily identify them. The implementation of this tag, however, can cause us to lose one of the other attributes if the tag is misplaced. I have a patch that fixes this.
Note: there's also some cleanup I want to do.
Status: NEW → ASSIGNED
Priority: -- → P4
Whiteboard: [patch]
Attached patch Fix (obsolete) — — Splinter Review
Attachment #209145 - Flags: superreview?(jst)
Attachment #209145 - Flags: review?(bugmail)
Comment on attachment 209145 [details] [diff] [review] Fix This is the wrong patch (even for the cleanup) :(
Attachment #209145 - Attachment is obsolete: true
Attachment #209145 - Flags: superreview?(jst)
Attachment #209145 - Flags: review?(bugmail)
Attached patch Fix (obsolete) — — Splinter Review
Attachment #209146 - Flags: superreview?(jst)
Attachment #209146 - Flags: review?(bugmail)
Comment on attachment 209146 [details] [diff] [review] Fix parser sucks
Attachment #209146 - Flags: review?(bugmail) → review+
Comment on attachment 209146 [details] [diff] [review] Fix sr=bzbarsky; sicking's right.
Attachment #209146 - Flags: superreview?(jst) → superreview+
Comment on attachment 209146 [details] [diff] [review] Fix Checked in.
Attachment #209146 - Attachment is obsolete: true
Attached patch Cleanup — — Splinter Review
This consolidates a duplicated block and (I think) fixes this bug independently of the previous patch. It also turns an if (...) if (...) into an if (...) else if (...) to avoid potential problems if the element table was tweaked incorrectly (such that an element had kSaveMisplaced _and_ kBadContentWatch set on it). I also got rid of a redundant if (aToken) check (if someone wants, I'll prove that it's redundant!). I'll attach a diff -w for easier viewing in a second.
Attachment #209155 - Flags: superreview?(jst)
Attachment #209155 - Flags: review?(bugmail)
Attached patch Cleanup -w — — Splinter Review
Comment on attachment 209155 [details] [diff] [review] Cleanup sr=jst
Attachment #209155 - Flags: superreview?(jst) → superreview+
Everything's been checked into the trunk. You guys are hard on the parser :-(.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
*** Bug 348832 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: