324182 - Userdefined tags can lose one of their attributes

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P4)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Userdefined tags get a special __moz-userdefined attributed pushed onto them so that editor can easily identify them. The implementation of this tag, however, can cause us to lose one of the other attributes if the tag is misplaced. I have a patch that fixes this.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Note: there's also some cleanup I want to do.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 209145 [details] [diff] [review]
Fix

This is the wrong patch (even for the cleanup) :(

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 209146 [details] [diff] [review]
Fix

parser sucks

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 209146 [details] [diff] [review]
Fix

sr=bzbarsky; sicking's right.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 209146 [details] [diff] [review]
Fix

Checked in.

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Cleanup

This consolidates a duplicated block and (I think) fixes this bug independently of the previous patch. It also turns an if (...) if (...) into an if (...) else if (...) to avoid potential problems if the element table was tweaked incorrectly (such that an element had kSaveMisplaced _and_ kBadContentWatch set on it). I also got rid of a redundant if (aToken) check (if someone wants, I'll prove that it's redundant!). I'll attach a diff -w for easier viewing in a second.

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Cleanup -w

Comment 10

[Johnny Stenback (:jst)]

Comment on attachment 209155 [details] [diff] [review]
Cleanup

sr=jst

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

Everything's been checked into the trunk. You guys are hard on the parser :-(.

Comment 12

[Blake Kaplan (:mrbkap) (inactive)]

*** Bug 348832 has been marked as a duplicate of this bug. ***