324209 - Default new tab/window preference is not respected until manually set

Status: RESOLVED WORKSFORME

(Firefox :: Settings UI, defect)

Description

[Ben Basson]

Sorry for the badly worded summary, I couldn't think how to accurately describe this, but it's hopefully of no real consequence being that it's a follow-up bug.

Steps to reproduce:
1. Create a new profile.
2. Navigate your way to Tools > Options > Tabs.
3. Note that the new window -> window/tab setting is set to "new tabs in the most recent window". Don't click on anything except "OK" or "Close" and thus exit the preferences UI
4. Go to http://forums.mozillazine.org/viewtopic.php?t=370221
5. Click any of links within the post (i.e. "Please file good memory leak bugs").

Expected results:
 - New tab

Actual results:
 - New window

If you click on the radiobutton for "new tabs in the most recent window" and then click "OK" (or "Close", whichever applies to you) and repeat the testcase, a new tab is opened as expected. 

I think all that needs doing here is to set browser.link.open_newwindow to 3 by default, since this is what clicking the preference radiobutton accomplishes.

Comment 1

[Ben Basson]

Attachment: Set browser.link.open_newwindow to 3

Comment 2

[Ben Basson]

I just got pointed to https://bugzilla.mozilla.org/show_bug.cgi?id=308396#c46 ... oops. I guess fixing this might avoid some dupes if it's going to be a while before the preferences are unified, though.

Comment 3

[Daniel C]

Why not fix it the other way round then for now, and have the radiobutton set to the actual preference, so that it's not confusing? I'm guessing it should just read in the preference when you open the Tabs tab and set itself (radiogroup) accordingly.