324230 - Context menu of last (only) tab has too many items

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, defect)

Description

[Peter van der Woude [:Peter6]]

the following items in the contextmenu in the last tab should be grayed out:

Reload all tabs (There is just 1 tab)
Close other tabs (There are no other tabs)
Close tab (The [X] on the tab was removed, so we shouldn't allow close here either)

Comment 1

[tabmix.onemen]

in tabbrowser.xml
      <method name="updatePopupMenu">
        <parameter name="aPopupMenu"/>
        <body>
          <![CDATA[
            this.mContextTab = document.popupNode;
            var disabled = this.mPanelContainer.childNodes.length == 1;
            var menuItems = aPopupMenu.getElementsByAttribute("tbattr", "tabbrowser-multiple");
            for (var i = 0; i < menuItems.length; i++)
              menuItems[i].disabled = disabled;
          ]]>
        </body>
      </method>


-  menuItems[i].disabled = disabled;
+  menuItems[i].setAttribute("disabled", disabled);

Comment 2

[Ben Basson]

Attachment: Comment 1 as a patch

Comment 3

[Anbo Motohiko]

(In reply to comment #1)
> in tabbrowser.xml
(snip)
> -  menuItems[i].disabled = disabled;
> +  menuItems[i].setAttribute("disabled", disabled);

This reverts an intended change made by Bug 288986. Is it OK?

Comment 4

[Ben Basson]

CCing Aaron. Currently some useless menu items aren't getting disabled which seems bad for usability, but is fixing this going to have an accessibility impact?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Why would it have an accessibility impact? If the items are useless, they're useless, doesn't matter how they're activacted...

Comment 6

[Ben Basson]

(In reply to comment #5)
> Why would it have an accessibility impact? If the items are useless, they're
> useless, doesn't matter how they're activacted...
 
Just double-checking, based on comment 3.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #6)
> (In reply to comment #5)
> > Why would it have an accessibility impact? If the items are useless, they're
> > useless, doesn't matter how they're activacted...
> 
> Just double-checking, based on comment 3.

Ah, I see, I hadn't looked at the patch. The change in that bug is incorrect - the menuitem binding doesn't extend general.xml, nor does it have a disabled property of it's own.  Maybe it should do one or the other instead of just using the attribute here, though.

Comment 8

[Simon Bünzli]

This bug should be WORKSFORME once bug 333023 has been fixed.

Comment 9

[Simon Bünzli]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7) Gecko/200708021010 GranParadiso/3.0a7

With bug 333023 fixed, this issue has indeed become WORKSFORME.