324235 - Poor description on show_all_products parameter

Status: RESOLVED WONTFIX

(Bugzilla :: Administration, task)

Description

[Paul]

Currently:
showallproducts
    If this is on and useclassification is set, Bugzilla will add a 'All' link in the 'New Bug' page to list all available products.

It's difficult to understand when you change the terminology mid-sentence.  Are settings on/off or set/cleared ?

Comment 1

[Mike Durthaler]

(In reply to comment #0)
> Currently:
> showallproducts
>     If this is on and useclassification is set, Bugzilla will add a 'All' link
> in the 'New Bug' page to list all available products.
> It's difficult to understand when you change the terminology mid-sentence.  Are
> settings on/off or set/cleared ?


Paul,

I'm a new guy to the forum here.  This bug and the one prior look simple enough to edit but ... and this may sound silly ... how do I get to the code to edit it?  Hey, I'm being honest!

I've used similar programs for working on .Net issues for another company.  I just need to know my way around here.

Thanks in advance.

Mike

Comment 2

[Mike Durthaler]

Attachment: Edited the showallproducts and use classification keys to fix the ambiguous terms issue Paul described.

Edited the needed resources to fix the ambiguous language issue.

Comment 3

[Mike Durthaler]

Oh, well ... I solved my access issue and handled the bug. (Actually, not a bug but a simple resource file edit :) )

Fix done was: Edit the bugfields.html.tmpl file to read as follows:

1) useclassification key now reads:
  useclassification => "If this flag is set true, $terms.Bugzilla will associate each product with a " _
                       "specific classification. But you must have 'editclassification' " _
                       "permissions enabled in order to edit classifications.",
2) showallproducts key now reads:
   showallproducts => "If this flag and useclassification are set true, $terms.Bugzilla will add an " _
                  "'All' link in the 'New $terms.Bug' page to list all available products.",

Attached file is submitted to QA.  I don't see how to change the Status from "NEW" to "RESOLVED" but this should do it.

Best,

Mike

Comment 4

[Frédéric Buclin]

Mike, do not attach the whole file. What we need is a patch, using either "cvs diff" against our current CVS installation or using "diff" against the original copy of the file.

Also, when you attach a file, you have to request review, else nobody will ever notice that you attached something. About the status of the bug, the one doing the checkin (after getting the appropriate review+ and approval+) will mark the bug as RESOLVED.

This comment also applies to other bugs where you attached something.

Comment 5

[Mike Durthaler]

Attachment: Here's the bugfields template patch

Here's the bugfields patch.

Comment 6

[Mike Durthaler]

(In reply to comment #4)
> Mike, do not attach the whole file. What we need is a patch, using either "cvs
> diff" against our current CVS installation or using "diff" against the original
> copy of the file.
> Also, when you attach a file, you have to request review, else nobody will ever
> notice that you attached something. About the status of the bug, the one doing
> the checkin (after getting the appropriate review+ and approval+) will mark the
> bug as RESOLVED.
> This comment also applies to other bugs where you attached something.

Thanks for your help Frederic.

I'm a windows guy, totally IDE, haven't touched a command window in over 10 years for any serious work.  :)

Here's the patch file for the bugfields.  Karl, my LAMP comrade-in-arms has the idea of using Cruise Control for faster managing of versioning. I'm thinking that's a good idea.

Mike

Comment 7

[Mike Durthaler]

My bad -- the patch I had sent up had psedo comments in it.

Here's the correct file without such comments.

Mike

Comment 8

[Mike Durthaler]

Attachment: bugfields template patch -- earlier one has pseudo remarks in it.

Comment 9

[Frédéric Buclin]

Mike, don't ask yourself for review. Ask an official reviewer, see http://www.bugzilla.org/docs/reviewer-list.html. But you are getting closer. :)

Comment 10

[Frédéric Buclin]

Comment on attachment 314166 [details] [diff] [review]
bugfields template patch -- earlier one has pseudo remarks in it.

>-  useclassification => "If this is on, $terms.Bugzilla will associate each product with a " _
>+  useclassification => "If this flag is set true, $terms.Bugzilla will associate each product

Mike, "flag" has another meaning in Bugzilla world. Could we use "parameter" instead?


>-  showallproducts => "If this is on and useclassification is set, $terms.Bugzilla will add a " _
>+   showallproducts => "If this flag and useclassification are set true, $terms.Bugzilla will

Same comment here.

Else your patch looks good. (sorry for the delay, but you put this review request in your own queue instead of putting it in the queue of an official reviewer)

Comment 11

[Nitish Bezzala]

"showallproducts" not used any more. 
This bug can be closed.

Comment 12

[Frédéric Buclin]

This parameter is gone since Bugzilla 3.4, see bug 399079.