324414 - caret blinking not themed

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

Steps to reproduce:
0) In GNOME control centre's Keyboard applet, uncheck "Blink cursor", or change the cursor blinking time
1) Start a gecko application (firefox, epiphany, etc.)

Result:
Cursor in text fields still blinks, resp. blinks at a different rate than the configured one.

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: look up cursor blink settings in GtkSettings

This patch exposes a bug in the caret drawing: when blinking is disabled, the caret doesn't initially show when you click into firefox' URL bar.

Comment 2

[Christian Persch (GNOME) (away; not receiving bug mail)]

The problem with nonshowing cursor with diabled blink might be bug 322720.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 209352 [details] [diff] [review]
look up cursor blink settings in GtkSettings

+            printf("blink %d blink-time %d\n", blink, blink_time);

lose this.

Comment 4

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: updated patch

Sorry about the accidentally left-over debug printf :)

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

go ahead and check in

Comment 6

[Christian Persch (GNOME) (away; not receiving bug mail)]

(In reply to comment #5)
> go ahead and check in

I can't, don't have cvs write access.

Comment 7

[Martijn Wargers (dead)]

Chpe, I can check the patch in for you, shall I do this?

Comment 8

[Christian Persch (GNOME) (away; not receiving bug mail)]

(In reply to comment #7)
> Chpe, I can check the patch in for you, shall I do this?

Yes, please :-)

Comment 9

[Martijn Wargers (dead)]

Checking in widget/src/gtk2/nsLookAndFeel.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsLookAndFeel.cpp,v  <--  nsLookAndFeel.cpp
new revision: 1.26; previous revision: 1.25
done

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

this is C++, you don't have to define all your variables at the start of the block. imo you also shouldn't, because it makes it harder to know the type of the variable (where it is used) and makes it harder to see whether it was already initialized.

Comment 11

[Christian Persch (GNOME) (away; not receiving bug mail)]

(In reply to comment #10)
> this is C++, you don't have to define all your variables at the start of the
> block. imo you also shouldn't, because it makes it harder to know the type of
> the variable (where it is used) and makes it harder to see whether it was
> already initialized.

You're right, but I oriented myself on the file's style, which is like this, look e.g. in "case eMetric_SelectTextfieldsOnKeyFocus".

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

:( ok, then.